lp://staging/~larsks/cloud-utils/bug-1807171
- Get this branch:
- bzr branch lp://staging/~larsks/cloud-utils/bug-1807171
Branch merges
- Scott Moser (community): Approve
-
Diff: 112 lines (+96/-1)2 files modifiedbin/growpart (+1/-1)
test/test-growpart-start-matches-size (+95/-0)
Related bugs
Bug #1807171: growpart fails if size of partition == start of partition | Medium | Fix Released |
Related blueprints
Branch information
Recent revisions
- 340. By Lars Kellogg-Stedman
-
Fix test for bug #1807171
The test in the previous commit did not actually verify that the
final partition table matched the desired configuration. - 339. By Lars Kellogg-Stedman
-
growpart: fix bug occurring if start sector and size were the same.
The existing sed expression would erroneously change the start sector
of a partition, rather than the size, if the start sector and size
were identical. This commit modifies the sed expression so that it
will only operate on the final match in the line.LP: #1807171
- 338. By Kevin Locke
-
growpart: Resolve symbolic links before operating.
Disks can be referred to via symlink aliases, such as the ones in
/dev/disk/by-id and /dev/disk/by-path. These alias paths can have
different partition naming behavior than the un-aliased path. For
example, both of the above aliases add -partX to the name for partition
X, rather than just X. Previously this would cause growpart to fail
with the error:failed to get start and end for ${dpart} in ${DISK}
Because the awk expression would not match the partition path. This
commit fixes the error by resolving symlink device paths before use. - 337. By Scott Moser
-
mount-image-
callback: fix mostly harmless typo in variable name. This typo actually had no real negative side effect because at the
point of use, UMOUNTS had no entries. So:
UMOUNTS[${BOGUS[ @]}]=x
is the same as the corrected version
UMOUNTS[${#UMOUNTS[ @]}]=x if UMOUNTS was an empty array at the time (which it was).
- 336. By Scott Moser
-
mount-image-
callback: fix typo meaning we never timed out waiting for a disk. simple typo 'i=$(($i+1)):' instead of i=$(($i+1))
meant that we'd never actually take the fail path. - 331. By Scott Moser
-
growpart: fix bug when resizing a middle partition with sgdisk.
Added a test and made growpart output consistent between sgdisk
and sfdisk resizers.
Thanks to Fred De Backer.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/cloud-utils