Merge lp://staging/~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Status: | Rejected |
---|---|
Rejected by: | Alan Pope πΊπ§π± π¦ |
Proposed branch: | lp://staging/~larryprice/ubuntu-terminal-app/fix-cmake-xenial |
Merge into: | lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot |
Diff against target: |
11 lines (+2/-0) 1 file modified
src/plugin/qmltermwidget/CMakeLists.txt (+2/-0) |
To merge this branch: | bzr merge lp://staging/~larryprice/ubuntu-terminal-app/fix-cmake-xenial |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Pope πΊπ§π± π¦ (community) | Disapprove | ||
Review via email: mp+297394@code.staging.launchpad.net |
Commit message
Update CMakeLists.txt to explicitly create QMLTermWidget directory.
Description of the change
Update CMakeLists.txt to explicitly create QMLTermWidget directory.
I noticed that the build was failing on xenial (locally + the daily recipe builds) and tracked it down to the first copy command in src/plugin/
See failing daily build on xenial: https:/
Unmerged revisions
- 205. By Larry Price
-
make_directory syntax
- 204. By Larry Price
-
Undo auto-whitespace updates
- 203. By Larry Price
-
Fixing xenial build by explicitly creating QMLTermWidget directory
Thanks Larry. Apologies for the lengthy delay in responding. As discussed on irc, this merge has been superseded.