Merge lp://staging/~larryprice/ubuntu-app-launch/recursive-desktop-files into lp://staging/ubuntu-app-launch/16.10
Proposed by
Larry Price
| Status: | Rejected |
|---|---|
| Rejected by: | Ted Gould |
| Proposed branch: | lp://staging/~larryprice/ubuntu-app-launch/recursive-desktop-files |
| Merge into: | lp://staging/ubuntu-app-launch/16.10 |
| Diff against target: |
520 lines (+179/-208) 8 files modified
libubuntu-app-launch/app-info.c (+94/-72) libubuntu-app-launch/application-impl-base.cpp (+26/-0) libubuntu-app-launch/application-impl-base.h (+2/-0) libubuntu-app-launch/application-impl-legacy.cpp (+19/-63) libubuntu-app-launch/application-impl-legacy.h (+0/-4) libubuntu-app-launch/application-impl-libertine.cpp (+23/-68) tests/libual-cpp-test.cc (+8/-1) tests/libual-test.cc (+7/-0) |
| To merge this branch: | bzr merge lp://staging/~larryprice/ubuntu-app-launch/recursive-desktop-files |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Recursively sweep for desktop files for libertine and legacy applications.
Description of the change
Recursively sweep for desktop files for libertine and legacy applications.
Goes hand-in-hand with an update to liblibertine which finds desktop files recursively https:/
To post a comment you must log in.
Unmerged revisions
- 236. By Larry Price
-
adding nested
- 235. By Larry Price
-
Quick tests to verify nested keyfiles are now being accepted
- 234. By Larry Price
-
moving keyfileFromPath to parent to reduce code dup
- 233. By Larry Price
-
Same treatment for legacy apps
- 232. By Larry Price
-
Updating Libertine ctor to find correct desktop file
- 231. By Larry Price
-
updating app-info to recursively find legacy apps
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
So I think this branch is gonna break when it gets merged with:
https:/
As it removes the app-info.h file. The goal generally is to have that C code go away and be replaced with C++ code. I think that will restructure things a bunch. Also you forgot to include test-nested.