Merge lp://staging/~larryprice/libertine-scope/libertine-store-create-container into lp://staging/~larryprice/libertine-scope/libertine-store-search
Proposed by
Larry Price
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~larryprice/libertine-scope/libertine-store-create-container |
| Merge into: | lp://staging/~larryprice/libertine-scope/libertine-store-search |
| Diff against target: |
1588 lines (+882/-88) 32 files modified
CMakeLists.txt (+2/-0) data/CMakeLists.txt (+4/-0) lib/libertine-scope/CMakeLists.txt (+1/-0) lib/libertine-scope/action.h (+1/-1) lib/libertine-scope/container.cpp (+50/-0) lib/libertine-scope/container.h (+44/-0) lib/libertine-scope/preview.cpp (+2/-2) lib/libertine-scope/service_manager.cpp (+23/-6) lib/libertine-scope/service_manager.h (+3/-0) scope/apps/action.cpp (+0/-1) scope/apps/action.h (+0/-1) scope/store/action.cpp (+43/-0) scope/store/action.h (+48/-0) scope/store/create_preview.cpp (+113/-0) scope/store/create_preview.h (+65/-0) scope/store/entry_point.cpp (+1/-1) scope/store/query.cpp (+56/-12) scope/store/query.h (+15/-13) scope/store/scope.cpp (+13/-7) scope/store/scope.h (+4/-7) service/libertine_service/container.py (+14/-4) service/libertine_service/dbus.py (+31/-10) service/libertine_service/tasks.py (+23/-7) tests/lib/libertine-scope/CMakeLists.txt (+3/-2) tests/lib/libertine-scope/mock_service_manager.h (+2/-0) tests/lib/libertine-scope/test_action.cpp (+3/-3) tests/lib/libertine-scope/test_container.cpp (+53/-0) tests/lib/libertine-scope/test_preview.cpp (+2/-2) tests/scope/store/CMakeLists.txt (+2/-0) tests/scope/store/test_action.cpp (+85/-0) tests/scope/store/test_create_preview.cpp (+137/-0) tests/scope/store/test_query.cpp (+39/-9) |
| To merge this branch: | bzr merge lp://staging/~larryprice/libertine-scope/libertine-store-create-container |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Libertine Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Warn user on data usage before container creation.
Description of the change
Warn user on data usage before container creation.
If the "palatine" container does not exist, present user with a special icon for creating the container. This takes the user to a special preview with a short warning message and the option to create the container.
I ended up changing some namespacing things here as I started running into collisions.
To post a comment you must log in.
Unmerged revisions
- 113. By Larry Price
-
further specify namespace for store scope
- 112. By Larry Price
-
Tests for new code
- 111. By Larry Price
-
Fix old tests
- 110. By Larry Price
-
Progress bar on create
- 109. By Larry Price
-
Special preview pane for creating the palatine container
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
