Ubuntu Calendar App

Merge lp://staging/~larochelle-brian/ubuntu-calendar-app/30MinIncrementsHackdays into lp://staging/ubuntu-calendar-app

  1. 30MinIncrementsHackdays
  2. Merge into trunk
Proposed by brian larochelle
Status: Superseded
Proposed branch: lp://staging/~larochelle-brian/ubuntu-calendar-app/30MinIncrementsHackdays
Merge into: lp://staging/ubuntu-calendar-app
Diff against target: 42 lines (+16/-2)
1 file modified
NewEvent.qml (+16/-2)
To merge this branch: bzr merge lp://staging/~larochelle-brian/ubuntu-calendar-app/30MinIncrementsHackdays
Reviewer Review Type Date Requested Status
Ubuntu Calendar Developers Pending
Review via email: mp+212904@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-03-27.

Commit message

  Event time selection should be in 30 min increments
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1297725

Description of the change

Added logic to NewEvent.qml to choose a default of either 0 or 30 for minutes for the TimePicker. If minutes are past 30, an hour is added.

To post a comment you must log in.
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

8 + startTime.defaultHour = (startDate.getMinutes() < 30) ? startDate.getHours() : startDate.getHours() + 1
19 + startTime.defaultMinute = (startDate.getMinutes() < 30) ? 30 : 0
20 + var popupObj = PopupUtils.open(timePicker,root,{"hour": startTime.defaultHour,"minute":startTime.defaultMinute});

Can we move above code to separate function ?

lp://staging/~larochelle-brian/ubuntu-calendar-app/30MinIncrementsHackdays updated
223. By brian larochelle

Move changes from rev 222 into functions of the root of NewEvent {}
change logic statements from ternary to if for readablity.

Revision history for this message
brian larochelle (larochelle-brian) wrote :

sure.

I moved the logic to functions off the root of NewEvent {} and changed the ternary statements to if statements to improve readability.

lp://staging/~larochelle-brian/ubuntu-calendar-app/30MinIncrementsHackdays updated
224. By brian larochelle

Fix copy paste error with rev 223

225. By brian larochelle

Fix copy/paste error.
Increment the endDate by 30 instread of 10

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: