Merge lp://staging/~laney/upstart/xsession-sessiontype into lp://staging/ubuntu/raring/upstart

Proposed by Iain Lane
Status: Merged
Merged at revision: 1437
Proposed branch: lp://staging/~laney/upstart/xsession-sessiontype
Merge into: lp://staging/ubuntu/raring/upstart
Diff against target: 41 lines (+14/-1)
3 files modified
debian/changelog (+7/-0)
debian/user-conf/xsession-init.conf (+1/-1)
debian/xsession.d/99upstart (+6/-0)
To merge this branch: bzr merge lp://staging/~laney/upstart/xsession-sessiontype
Reviewer Review Type Date Requested Status
Stéphane Graber Approve
James Hunt Pending
Review via email: mp+153412@code.staging.launchpad.net

Description of the change

Currently the gnome-session user job's start on condition is

  start on xsession SESSION=ubuntu

which seems overly specific. That job can work for any gnome-session.

While the Xsession.d scripts are being processed, there is a $BASESTARTUP variable set in 55gnome-session_gnomerc that we can use to determine which session manager is being used. Currently we only look for gnome-session but others could extend this if they wish.

If accepted, I'll modify gnome-session's job accordingly.

To post a comment you must log in.
1434. By Iain Lane

Quote variable

Revision history for this message
Stéphane Graber (stgraber) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: