unity8-desktop-session

Merge lp://staging/~laney/unity8-desktop-session/tweaks into lp://staging/unity8-desktop-session

  1. tweaks
  2. Merge into trunk
Proposed by Iain Lane
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 51
Merged at revision: 53
Proposed branch: lp://staging/~laney/unity8-desktop-session/tweaks
Merge into: lp://staging/unity8-desktop-session
Diff against target: 58 lines (+7/-2)
6 files modified
data/10-unity8-x11.conf (+2/-0)
data/55-unity8.conf (+1/-0)
data/Makefile.am (+1/-0)
data/unity8-mir.conf.in (+1/-1)
debian/unity8-desktop-session-mir.install (+1/-1)
debian/unity8-desktop-session-x11.install (+1/-0)
To merge this branch: bzr merge lp://staging/~laney/unity8-desktop-session/tweaks
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Review via email: mp+219883@code.staging.launchpad.net

Commit message

Make the sessions the default if they are installed, so that automatic logging in in the iso works. Use the Upstart idiomatic --no-wait instead of & in pre-start.

Description of the change

I needed to make the sessions the default for the new flavour to autologin in live mode. Other flavours do similar things. If you don't have this then lightdm tries 'ubuntu' which doesn't work.

There's another opportunistic fix, can make it a separate branch if you want.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Unity 8 takes longer to start up with this patch and there's no visual indication that it's not ot is ready. That needs to be addressed by a later patch, given that this proposal fixes a serious problem in sessioon logout.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

On Wed, May 28, 2014 at 02:39:34PM -0000, Stephen M. Webb wrote:
> Review: Approve
>
> Unity 8 takes longer to start up with this patch and there's no visual indication that it's not ot is ready. That needs to be addressed by a later patch, given that this proposal fixes a serious problem in sessioon logout.

Thanks. Do you know what makes it take longer?

Any chance we can train this quite quickly so that the next -next image
build has the fix and autologin works there?

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Stephen M. Webb (bregma) wrote :

I'm revoking my approval for this because the lightdm files should probably be installed into /etc/lightdm/lightdm.conf.d (conffiles can cause problems on package removal). That also allows the contents of 20-unity8-mir.conf to be merged into 55-unity8-mir.conf to avoid possible confusion from having two different conf files for the same thing with different contents.

review: Needs Fixing
lp://staging/~laney/unity8-desktop-session/tweaks updated
51. By Iain Lane

Install in /usr/share/lightdm/lightdm.conf.d from the upstream packaging instead of debian/

Revision history for this message
Iain Lane (laney) wrote :

Okay, could you try this one please?

Revision history for this message
Stephen M. Webb (bregma) wrote :

OK

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

On Mon, Jun 02, 2014 at 04:10:34PM -0000, Stephen M. Webb wrote:
> Review: Approve
>
> OK

Thanks Stephen. Can we have this uploaded soon?

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches