Merge lp://staging/~laney/unity-lens-photos/handle-libaccounts-failure into lp://staging/unity-lens-photos
Proposed by
Iain Lane
| Status: | Merged |
|---|---|
| Approved by: | David Callé |
| Approved revision: | 101 |
| Merged at revision: | 101 |
| Proposed branch: | lp://staging/~laney/unity-lens-photos/handle-libaccounts-failure |
| Merge into: | lp://staging/unity-lens-photos |
| Diff against target: |
50 lines (+15/-3) 3 files modified
src/facebook_scope.py (+5/-1) src/flickr_scope.py (+5/-1) src/picasa_scope.py (+5/-1) |
| To merge this branch: | bzr merge lp://staging/~laney/unity-lens-photos/handle-libaccounts-failure |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Callé | Approve | ||
|
Review via email:
|
|||
Description of the change
We need to handle failure to open the accounts database otherwise the lens crashes. This code seems to be mostly duplicated between scopes already.
Perhaps some refactoring to attempt the DB opening sooner could make us return earlier, freeing up resources in the case where it fails.
(I also noticed quite a few unused imports that you may want to clean up).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking good. Thanks Iain.
I will push some cleaning in another branch.