Music Lens

Merge lp://staging/~laney/unity-lens-music/gstreamer1.0 into lp://staging/unity-lens-music

  1. gstreamer1.0
  2. Merge into trunk
Proposed by Iain Lane
Status: Rejected
Rejected by: Michael Terry
Proposed branch: lp://staging/~laney/unity-lens-music/gstreamer1.0
Merge into: lp://staging/unity-lens-music
Diff against target: 212 lines (+33/-25)
5 files modified
configure.ac (+3/-3)
debian/changelog (+6/-0)
debian/control (+3/-3)
src/Makefile.am (+2/-2)
src/player.vala (+19/-17)
To merge this branch: bzr merge lp://staging/~laney/unity-lens-music/gstreamer1.0
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry Approve
Review via email: mp+134310@code.staging.launchpad.net

Commit message

Port from gstreamer 0.10 to gstreamer 1.0

Description of the change

For Raring, we want to port everything in main from gstreamer-0.10 to gstreamer-1.0.

unity-lens-music is on that list. This branch implements the port.

I'm sure there are still gremlins ("soft" 0.10/1.0 changes) that will need to be ironed out, but in my testing this performed as well before the port as after. (That is, not spectacularly - previews still frequently fail to play - but it at least works).

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

BTW if you want to test you should manually install gstreamer1.0-{pulseaudio,alsa} and the plugins they need, otherwise you won't get any sound. :-)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Please, do not merge until Laney gives the green light, meaning gstreamer 1.0 in main :)

Revision history for this message
Michael Terry (mterry) wrote :

Looks fine to me, and it does seem to work as well in my quick testing (it only uses it for preview mode music playing, right?).

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Oh wait. Is there not a bug for this? Can you open one and link it please before it gets approved for a proper debian/changelog entry?

Revision history for this message
Michael Terry (mterry) wrote :

Laney is on holiday, whoops. I went ahead and made a bug and linked it. Approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-lens-music-mbs-autolanding/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-music-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-music-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/7/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

To resolve the merge conflict, since laney is on vacation, I made: https://code.launchpad.net/~mterry/unity-lens-music/gst1/+merge/139031

So I'll mark this branch as rejected.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: