Merge lp://staging/~laney/unity-greeter/data-package into lp://staging/unity-greeter

Proposed by Iain Lane
Status: Needs review
Proposed branch: lp://staging/~laney/unity-greeter/data-package
Merge into: lp://staging/unity-greeter
Diff against target: 55 lines (+15/-1)
4 files modified
debian/control (+8/-0)
debian/rules (+1/-1)
debian/unity-greeter-data.install (+1/-0)
debian/unity-greeter.install (+5/-0)
To merge this branch: bzr merge lp://staging/~laney/unity-greeter/data-package
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity Greeter Development Team Pending
Review via email: mp+207644@code.staging.launchpad.net

Commit message

Split images out into a -data package that can be depended on by others.

Description of the change

Split the png files out into a -data package which unity will be able to depend on for the logo for its lock screen.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1145
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~laney/unity-greeter/data-package/+merge/207644/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/37/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-greeter-trusty-amd64-ci/20/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-greeter-trusty-armhf-ci/20

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-greeter-ci/37/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Is this still required?

Revision history for this message
Iain Lane (laney) wrote :

On Wed, Mar 19, 2014 at 02:43:29AM -0000, Robert Ancell wrote:
> Is this still required?

I think so - we should check with the Unity team if their lock screen
can make use of this.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Unmerged revisions

1145. By Iain Lane

Depends, not Recommends

1144. By Iain Lane

Missed a }

1143. By Iain Lane

Fix .install

1142. By Iain Lane

Bah, use -T

1141. By Iain Lane

Create the directories

1140. By Iain Lane

Install logo.png there too

1139. By Iain Lane

Split out a unity-greeter-data package containing images.

The main reason is that logo.png can be shared with other applications without
needing to depend on the whole greeter.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches