ubuntu-system-settings

Merge lp://staging/~laney/ubuntu-system-settings/reset-background into lp://staging/ubuntu-system-settings

  1. reset-background
  2. Merge into trunk
Proposed by Iain Lane
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~laney/ubuntu-system-settings/reset-background
Merge into: lp://staging/ubuntu-system-settings
Prerequisite: lp://staging/~laney/ubuntu-system-settings/reset-api
Diff against target: 18 lines (+9/-0)
1 file modified
plugins/background/MainPage.qml (+9/-0)
To merge this branch: bzr merge lp://staging/~laney/ubuntu-system-settings/reset-background
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Touch System Settings Pending
Review via email: mp+210261@code.staging.launchpad.net

Commit message

[background] Support resetting to default

Description of the change

I wanted to show that we can start adding reset support to plugins now.

It's a little bit hard to test this because content hub is broken when you launch from the command line and the reset plugin is hidden by default. I suggest you hack reset.settings to make it shown by default.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:505
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/690/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3789
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3376
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-amd64-ci/206
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-armhf-ci/194
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-trusty-i386-ci/193
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3330
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3807
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3807/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3378
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3378/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5746
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4630

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/690/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

setting as rejected since the panel got refactored since the changes were submitted

Unmerged revisions

505. By Iain Lane

Reset support for the background plugin

504. By Iain Lane

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches