Merge lp://staging/~laney/ubiquity/webkit2 into lp://staging/ubiquity

thanks for the work, it doesn't work for me though (using the version published in a ppa an hour ago), the slides don't display

/var/log/installer/debug has

"sys:1: PyGIWarning: WebKit2 was imported without specifying a version first. Use gi.require_version('WebKit2', '4.0') before import to ensure that the right version gets loaded.

(process:8709): Gtk-WARNING **: This process is currently running setuid or setgid.
This is not a supported use of GTK+. You must create a helper
program instead. For further details, see:

    http://www.gtk.org/setuid.html

Refusing to initialize GTK+."

one other small thing
"# True will not sure the menu"

is that a typo sure->show?

could you also version the import to avoid the require_version warning?

On Tue, Feb 09, 2016 at 02:54:18PM -0000, Sebastien Bacher wrote:
> Review: Needs Fixing
>
> thanks for the work, it doesn't work for me though (using the version published in a ppa an hour ago), the slides don't display

Try again from the PPA please. All should be fixed.

I did this to test it from a live session:

  $ sudo sed -i 's/main/main universe/' /etc/apt/sources.list
  $ sudo add-apt-repository ppa:laney/wk2
  $ sudo apt update
  $ sudo apt install ubiquity ubiquity-frontend-kde- # recommends? don't need the kdeish bits to test this

Then close terminal and launch using the desktop file on the desktop.

This

  http://people.canonical.com/~laney/weird-things/zlidezhow.png

is a screenshot of it which I took just now.

Cheers,

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

On 10 February 2016 at 15:12, Iain Lane <email address hidden> wrote:
> On Tue, Feb 09, 2016 at 02:54:18PM -0000, Sebastien Bacher wrote:
>> Review: Needs Fixing
>>
>> thanks for the work, it doesn't work for me though (using the version published in a ppa an hour ago), the slides don't display
>
> Try again from the PPA please. All should be fixed.
>
> I did this to test it from a live session:
>
> $ sudo sed -i 's/main/main universe/' /etc/apt/sources.list
> $ sudo add-apt-repository ppa:laney/wk2
> $ sudo apt update
> $ sudo apt install ubiquity ubiquity-frontend-kde- # recommends? don't need the kdeish bits to test this
>

for historical reasons we depends on : ubiquity-frontend-kde |
ubiquity-frontend-gtk

So one can do:

$ sudo apt install ubiquity ubiquity-frontend-gtk

to upgrade it mid flight.

> Then close terminal and launch using the desktop file on the desktop.
>
> This
>
> http://people.canonical.com/~laney/weird-things/zlidezhow.png
>
> is a screenshot of it which I took just now.
>
> Cheers,
>
> --
> Iain Lane [ <email address hidden> ]
> Debian Developer [ <email address hidden> ]
> Ubuntu Developer [ <email address hidden> ]
>
> https://code.launchpad.net/~laney/ubiquity/webkit2/+merge/282467
> You are subscribed to branch lp:ubiquity.

--
Regards,

Dimitri.

the updated version works fine here, tried on yesterday's daily with the ppa, the slides display as they should, you can switch to next/previous ones and clicking on an url in summary slide opens the webbrowser on the correct url

LGTM.