ubiquity

Merge lp://staging/~laney/ubiquity/dbus-session-bus into lp://staging/ubiquity

dbus-session-bus
Merge into trunk

Proposed by Iain Lane on 2018-04-23

Status:	Merged
Merged at revision:	6624
Proposed branch:	lp://staging/~laney/ubiquity/dbus-session-bus
Merge into:	lp://staging/ubiquity
Diff against target:	93 lines (+16/-8) 4 files modified data/ubiquity.desktop.in (+1/-1) debian/changelog (+5/-0) ubiquity/gsettings.py (+7/-4) ubiquity/misc.py (+3/-3)
To merge this branch:	bzr merge lp://staging/~laney/ubiquity/dbus-session-bus
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Sebastien Bacher	2018-04-23	Approve on 2018-04-24
Ubuntu Installer Team	2018-04-23	Pending
Review via email: mp+343838@code.staging.launchpad.net

Description of the change

Pass user session bus address through from desktop into ubiquity, & execute gsettings with that bus.

Also use SUDO_UID if PKEXEC_UID is not set.

Revision history for this message

Iain Lane (laney) wrote on 2018-04-23:

This is an alternative to https://code.launchpad.net/~seb128/ubiquity/gsettings-calls-environ/+merge/343829

Revision history for this message

Sebastien Bacher (seb128) wrote on 2018-04-23:

Looks good to me, thanks!

review: Approve

Revision history for this message

Iain Lane (laney) wrote on 2018-04-24:

My bad, I accidentally pushed this to trunk before an ~ubuntu-installer member reviewed.

Feel free to do so, or it'll get reviewed in the unapproved queue anyway.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2018-04-24:

the version pushed with the extra XDG_RUNTIME_DIR env looks good/works fine, +1 from but I'm not in the ~ubuntu-installer so my review might not count

review: Approve