Merge lp://staging/~laney/telephony-service/libphonenumber7.1.0 into lp://staging/telephony-service
Proposed by
Iain Lane
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~laney/telephony-service/libphonenumber7.1.0 |
| Merge into: | lp://staging/telephony-service |
| Diff against target: |
23 lines (+3/-3) 1 file modified
tests/Ubuntu.Telephony/tst_PhoneNumberPhoneUtils.qml (+3/-3) |
| To merge this branch: | bzr merge lp://staging/~laney/telephony-service/libphonenumber7.1.0 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Ken VanDine | Pending | ||
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
Update international test number to be valid with libphonenumber 7.1.0
Description of the change
I've been working with the Debian maintainer of libphonenumber to get our packages in sync.
As of libphonenumber 7.1.0-2, which I uploaded today, it can be synced.
libphonenumber fails one test now - the international number given isn't matched by the new metadata in this version. Is it because the given number is not actually valid? If so, I've updated it by changing one digit and the test now passes again. Other countries, for example numbers in the UK, also work.
To post a comment you must log in.
Revision history for this message
| Iain Lane (laney) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Iain Lane (laney) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Once we get synced, Daniel (Debian maintainer) is keen to keep the package that way. That means that future changes should be submitted to upstream and to him (e.g. via email or the Debian BTS) please.