Merge lp://staging/~laney/software-properties/test-fixes into lp://staging/software-properties
Proposed by
Iain Lane
| Status: | Merged |
|---|---|
| Merge reported by: | Scott Moser |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~laney/software-properties/test-fixes |
| Merge into: | lp://staging/software-properties |
| Diff against target: |
43 lines (+12/-2) 3 files modified
debian/changelog (+10/-0) debian/tests/run-tests (+1/-1) softwareproperties/shortcuts.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~laney/software-properties/test-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimitri John Ledkov | Pending | ||
| Scott Moser | Pending | ||
| Ubuntu Core Development Team | Pending | ||
|
Review via email:
|
|||
Description of the change
AFAICS the change from https:/
I think that add_key() needs to return a boolean. The one in ShortcutHandler constantly succeeds, so it seems that it should return True all the time. Please sanity check this.
Also the autopkgtests call gpg1 which isn't installed any more - I think they can just call gpg instead. At least they pass for me like this.
To reproduce, with working lxd:
$ autopkgtest-
$ autopkgtest --shell-fail -U --apt-pocket=
To post a comment you must log in.
Revision history for this message
| Iain Lane (laney) wrote | # |
Revision history for this message
| Iain Lane (laney) wrote | # |
Revision history for this message
| Scott Moser (smoser) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Oh, to reproduce the failure, pass 'software-