Ubuntu Software Center

Merge lp://staging/~laney/software-center/actionbar-class into lp://staging/software-center

  1. actionbar-class
  2. Merge into trunk
Proposed by Iain Lane
Status: Merged
Approved by: dobey
Approved revision: 3323
Merged at revision: 3324
Proposed branch: lp://staging/~laney/software-center/actionbar-class
Merge into: lp://staging/software-center
Diff against target: 14 lines (+4/-0)
1 file modified
softwarecenter/ui/gtk3/widgets/actionbar.py (+4/-0)
To merge this branch: bzr merge lp://staging/~laney/software-center/actionbar-class
Reviewer Review Type Date Requested Status
dobey Approve
Michael Vogt (community) Approve
Lars Karlitski Pending
Review via email: mp+253668@code.staging.launchpad.net

Commit message

Add a style class for the action bar.

Description of the change

Add a style class for the action bar, so that we can give it some theming. (Currently a bug means it's transparent in 15.04)

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

LGTM

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

thanks, could you merge + ideally upload? :)

Revision history for this message
Michael Vogt (mvo) wrote :

I would love to merge/upload, I top-level approved, I'm not sure why tarmac has not merged it automatically. I also don't know where the packaging branch is. I added dobey to this MP, maybe he can help and tell me/us where the debian/ part of the source is stored.

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0, Pending == 0. Got: 1 Approve, 1 Pending.

Revision history for this message
dobey (dobey) wrote :

Looks ok.

A commit message is required to be set for landing to work.

The source tree was cleaned up a bit and made to be a non-native package a few years ago, so there is no debian/ directory in the tree any more. There's a version definition in setup.py, and we were using tarball releases for the last several new release uploads.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.