Autopilot Qt Support

Merge lp://staging/~laney/autopilot-qt/no-hardcode-xpathselect into lp://staging/autopilot-qt/wily

no-hardcode-xpathselect
Merge into wily

Proposed by Christopher Lee on 2015-08-24

Status:	Needs review
Proposed branch:	lp://staging/~laney/autopilot-qt/no-hardcode-xpathselect
Merge into:	lp://staging/autopilot-qt/wily
Diff against target:	13 lines (+1/-2) 1 file modified debian/control (+1/-2)
To merge this branch:	bzr merge lp://staging/~laney/autopilot-qt/no-hardcode-xpathselect
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Max Brustkern (community)			Approve on 2015-08-28
Marco Trevisan (Treviño) (community)		2015-08-24	Approve on 2015-08-26
PS Jenkins bot	continuous-integration	2015-08-24	Pending
Review via email: mp+268987@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-08-24.

Description of the change

Don't hardcode the xpathselect dependency - it should be auto detected.

Note that I can't verify this because the tests fail

FAIL! : tst_Introspection::test_introspect(/) Compared values are not the same
   Actual (first_object.state.value(firstResultPropertyName)): QVariant(QVariantList,<value not representable as string>)
   Expected (firstResultPropertyValue) : QVariant(QVariantList,<value not representable as string>)
   Loc: [../../../tests/unittests/tst_introspection.cpp(265)]
FAIL! : tst_Introspection::test_introspect(//QWidget[id=6]) Compared values are not the same
   Actual (resultList.count()): 0
   Expected (resultCount) : 1
   Loc: [../../../tests/unittests/tst_introspection.cpp(259)]
FAIL! : tst_Introspection::test_introspect(//QPushButton[id=9]) Compared values are not the same
   Actual (resultList.count()): 0
   Expected (resultCount) : 1
   Loc: [../../../tests/unittests/tst_introspection.cpp(259)]

...please could you help me understand why and fix this?

Then branch off this branch and upload to silo 019.

Revision history for this message

Iain Lane (laney) wrote on 2015-08-24: Posted in a previous version of this proposal

If you try to fix this, please test against the xpathselect in silo 019 currently.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-24: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:93
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~laney/autopilot-qt/no-hardcode-xpathselect/+merge/268943/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/30/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-wily-i386-ci/1/console