Ubuntu
update-notifier package

Merge ~lamoura/ubuntu/+source/update-notifier:focal-esm-updates into ubuntu/+source/update-notifier:ubuntu/focal-devel

  1. Git
  2. lp:~lamoura/ubuntu/+source/update-notifier
  3. focal-esm-updates
  4. Merge into ubuntu/focal-devel
Proposed by Lucas Albuquerque Medeiros de Moura
Status: Merged
Approved by: Bryce Harrington
Approved revision: df4ac9328526929f5776c3dcdb2d1b3ac8beb7b0
Merged at revision: df4ac9328526929f5776c3dcdb2d1b3ac8beb7b0
Proposed branch: ~lamoura/ubuntu/+source/update-notifier:focal-esm-updates
Merge into: ubuntu/+source/update-notifier:ubuntu/focal-devel
Diff against target: 725 lines (+440/-63)
4 files modified
data/apt_check.py (+118/-32)
debian/changelog (+17/-0)
debian/control (+1/-0)
tests/test_motd.py (+304/-31)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Review via email: mp+402785@code.staging.launchpad.net

Description of the change

Currently, update-notifier is showing esm-apps alerts if the distro is in ESM mode or is an LTS one. We are changing that to only show esm-apps alerts if the distro is an LTS but non-ESM distro.

Furthermore, we are also bringing back the:
0 updates can be applied immediately.

When we have 0 upgrades to be applied in the system.

Finally, we are also removing the use of lsb_release in apt_check.py to source the /etc/os-release file directly.

For this SRU, we are using this launchpad bug:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926990

And we are uploading the new packages into this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

I've verified the changes, build, and autopkgtest, all look good.
Modulo changes requested on MP #402787, this LGTM.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks LGTM +1

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

triage-focal+20.04:~/pkg/UpdateNotifier/review-mp402785$ dput ubuntu update-notifier_3.192.30.8_source.changes
Checking signature on .changes
gpg: /home/bryce/pkg/UpdateNotifier/review-mp402785/update-notifier_3.192.30.8_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/UpdateNotifier/review-mp402785/update-notifier_3.192.30.8.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading update-notifier_3.192.30.8.dsc: done.
  Uploading update-notifier_3.192.30.8.tar.xz: done.
  Uploading update-notifier_3.192.30.8_source.buildinfo: done.
  Uploading update-notifier_3.192.30.8_source.changes: done.
Successfully uploaded packages.
triage-focal+20.04:~/pkg/UpdateNotifier/review-mp402785/update-notifier-gu$ git ubuntu tag --upload
triage-focal+20.04:~/pkg/UpdateNotifier/review-mp402785/update-notifier-gu$ git push pkg upload/3.192.30.8
Enumerating objects: 53, done.
Counting objects: 100% (53/53), done.
Delta compression using up to 12 threads
Compressing objects: 100% (19/19), done.
Writing objects: 100% (45/45), 10.12 KiB | 942.00 KiB/s, done.
Total 45 (delta 36), reused 26 (delta 26)
To ssh://git.launchpad.net/ubuntu/+source/update-notifier
 * [new tag] upload/3.192.30.8 -> upload/3.192.30.8

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches