Merge lp://staging/~lachlan-mulcahy/percona-xtrabackup/1.6-bug903984 into lp://staging/percona-xtrabackup/1.6

Proposed by Lachlan Mulcahy
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 312
Proposed branch: lp://staging/~lachlan-mulcahy/percona-xtrabackup/1.6-bug903984
Merge into: lp://staging/percona-xtrabackup/1.6
Diff against target: 50 lines (+34/-8)
1 file modified
innobackupex (+34/-8)
To merge this branch: bzr merge lp://staging/~lachlan-mulcahy/percona-xtrabackup/1.6-bug903984
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Stewart Smith Pending
Review via email: mp+86127@code.staging.launchpad.net

Commit message

Fixed bug 903984.
When applying incremental deltas to a backup dir:

If a new xtrabackup_slave_info exists in the incremental delta dir, we update the target dir with the new file
If there is no xtrabackup_slave_info file in the incremental delta dir, we simply remove the xtrabackup_slave_info file from the target dir, to prevent the slave position information being used incorrectly.

Description of the change

Fixed bug 903984.
When applying incremental deltas to a backup dir:

If a new xtrabackup_slave_info exists in the incremental delta dir, we update the target dir with the new file
If there is no xtrabackup_slave_info file in the incremental delta dir, we simply remove the xtrabackup_slave_info file from the target dir, to prevent the slave position information being used incorrectly.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Looks good to me. No test case is possible, because the test suite doesn't support replication tests.

review: Approve
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches