Merge lp://staging/~kyrofa/unity-scope-snappy/scope_refactor into lp://staging/~unity-api-team/unity-scope-snappy/trunk
Proposed by
Kyle Fazzari
| Status: | Merged |
|---|---|
| Approved by: | Kyle Fazzari |
| Approved revision: | 24 |
| Merged at revision: | 11 |
| Proposed branch: | lp://staging/~kyrofa/unity-scope-snappy/scope_refactor |
| Merge into: | lp://staging/~unity-api-team/unity-scope-snappy/trunk |
| Diff against target: |
2275 lines (+1648/-343) 33 files modified
README (+2/-2) debian/rules (+1/-2) main.go (+29/-0) scope.ini (+5/-0) scope/action_runner.go (+39/-0) scope/action_runner_test.go (+44/-0) scope/fake_package_manager_test.go (+78/-0) scope/fake_widget_receiver_test.go (+88/-0) scope/generic_package_preview_template.go (+72/-0) scope/generic_package_preview_template_test.go (+172/-0) scope/install_action_runner.go (+39/-0) scope/install_action_runner_test.go (+42/-0) scope/installed_package_preview_template.go (+53/-0) scope/installed_package_preview_template_test.go (+89/-0) scope/open_action_runner.go (+32/-0) scope/open_action_runner_test.go (+17/-0) scope/package_manager.go (+15/-0) scope/package_preview.go (+44/-0) scope/package_preview_template.go (+19/-0) scope/package_preview_test.go (+87/-0) scope/preview_generator.go (+26/-0) scope/preview_generator_test.go (+37/-0) scope/scope.go (+220/-0) scope/scope_test.go (+87/-0) scope/store_package_preview_template.go (+65/-0) scope/store_package_preview_template_test.go (+101/-0) scope/uninstall_action_runner.go (+39/-0) scope/uninstall_action_runner_test.go (+42/-0) snappy-scope/main.go (+0/-299) snappy-scope/snappy-scope.ini (+0/-5) test_coverage.sh (+23/-0) webdm/client_server_test.go (+23/-23) webdm/package.go (+18/-12) |
| To merge this branch: | bzr merge lp://staging/~kyrofa/unity-scope-snappy/scope_refactor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Xavi Garcia (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Unity API Team | Pending | ||
|
Review via email:
|
|||
Commit message
Refactor the Snappy Scope to increase testability and extensibility.
Description of the change
Refactor the Snappy Scope to increase testability and extensibility in anticipation of progress placeholder widgets.
To post a comment you must log in.
Revision history for this message
| Kyle Fazzari (kyrofa) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Kyle Fazzari (kyrofa) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Look good to me.
I would probably need more time to review more in deep, as the MP is pretty large, but in the meantime I've added some comments inline (minor things)
Testing coverage is awesome and code is very easy to read.
What I'd like to discuss is if it's good to have the actual go-unityscopes code inside the project....