Merge lp://staging/~kyrofa/unity-scope-snappy/extract_action_runners into lp://staging/~unity-api-team/unity-scope-snappy/trunk
Proposed by
Kyle Fazzari
| Status: | Merged |
|---|---|
| Approved by: | Kyle Fazzari |
| Approved revision: | 44 |
| Merged at revision: | 21 |
| Proposed branch: | lp://staging/~kyrofa/unity-scope-snappy/extract_action_runners |
| Merge into: | lp://staging/~unity-api-team/unity-scope-snappy/trunk |
| Prerequisite: | lp://staging/~kyrofa/unity-scope-snappy/extract_package_manager |
| Diff against target: |
1699 lines (+657/-633) 41 files modified
store/action_runner.go (+0/-51) store/action_runner_test.go (+0/-50) store/actions/install_runner.go (+45/-0) store/actions/install_runner_test.go (+56/-0) store/actions/ok_runner.go (+31/-0) store/actions/ok_runner_test.go (+34/-0) store/actions/open_runner.go (+32/-0) store/actions/open_runner_test.go (+18/-0) store/actions/refresh_installing_runner.go (+40/-0) store/actions/refresh_installing_runner_test.go (+37/-0) store/actions/refresh_uninstalling_runner.go (+41/-0) store/actions/refresh_uninstalling_runner_test.go (+37/-0) store/actions/runner.go (+50/-0) store/actions/runner_test.go (+50/-0) store/actions/uninstall_runner.go (+45/-0) store/actions/uninstall_runner_test.go (+56/-0) store/install_action_runner.go (+0/-44) store/install_action_runner_test.go (+0/-55) store/installed_package_preview_template.go (+3/-2) store/installed_package_preview_template_test.go (+5/-4) store/installing_preview.go (+3/-2) store/installing_preview_test.go (+5/-4) store/ok_action_runner.go (+0/-31) store/ok_action_runner_test.go (+0/-33) store/open_action_runner.go (+0/-33) store/open_action_runner_test.go (+0/-18) store/preview_generator.go (+5/-4) store/preview_generator_test.go (+36/-35) store/progress/hack.go (+10/-0) store/refresh_installing_action_runner.go (+0/-39) store/refresh_installing_action_runner_test.go (+0/-36) store/refresh_uninstalling_action_runner.go (+0/-40) store/refresh_uninstalling_action_runner_test.go (+0/-36) store/scope.go (+2/-8) store/store_package_preview_template.go (+2/-1) store/store_package_preview_template_test.go (+3/-2) store/uninstall_action_runner.go (+0/-44) store/uninstall_action_runner_test.go (+0/-55) store/uninstalling_preview.go (+3/-2) store/uninstalling_preview_test.go (+5/-4) test_coverage.sh (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~kyrofa/unity-scope-snappy/extract_action_runners |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Xavi Garcia (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Unity API Team | Pending | ||
|
Review via email:
|
|||
Commit message
Extract scope ActionRunners into their own package.
Description of the change
Extract scope ActionRunners into their own package.
This is a simple reorganization-- the root of the store scope was getting cluttered.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:43
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://