Merge lp://staging/~kyrofa/unity-scope-snappy/dbusify_action_runners into lp://staging/~unity-api-team/unity-scope-snappy/trunk

Proposed by Kyle Fazzari
Status: Merged
Approved by: Kyle Fazzari
Approved revision: 53
Merged at revision: 25
Proposed branch: lp://staging/~kyrofa/unity-scope-snappy/dbusify_action_runners
Merge into: lp://staging/~unity-api-team/unity-scope-snappy/trunk
Prerequisite: lp://staging/~kyrofa/unity-scope-snappy/dbus_client
Diff against target: 793 lines (+408/-57)
26 files modified
README (+11/-1)
store/actions/cancel_uninstall_runner.go (+32/-0)
store/actions/cancel_uninstall_runner_test.go (+29/-0)
store/actions/confirm_uninstall_runner.go (+48/-0)
store/actions/confirm_uninstall_runner_test.go (+60/-0)
store/actions/failed_runner.go (+37/-0)
store/actions/failed_runner_test.go (+34/-0)
store/actions/finished_runner.go (+38/-0)
store/actions/finished_runner_test.go (+34/-0)
store/actions/install_runner.go (+2/-2)
store/actions/install_runner_test.go (+5/-4)
store/actions/ok_runner.go (+1/-1)
store/actions/ok_runner_test.go (+5/-10)
store/actions/open_runner.go (+1/-1)
store/actions/open_runner_test.go (+1/-3)
store/actions/refresh_installing_runner.go (+1/-1)
store/actions/refresh_installing_runner_test.go (+1/-3)
store/actions/refresh_uninstalling_runner.go (+1/-1)
store/actions/refresh_uninstalling_runner_test.go (+1/-3)
store/actions/runner.go (+25/-9)
store/actions/runner_test.go (+4/-0)
store/actions/uninstall_runner.go (+2/-2)
store/actions/uninstall_runner_test.go (+2/-2)
store/operation/metadata.go (+18/-0)
store/packages/dbus_manager.go (+1/-1)
store/scope.go (+14/-13)
To merge this branch: bzr merge lp://staging/~kyrofa/unity-scope-snappy/dbusify_action_runners
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Xavi Garcia (community) Approve
Unity API Team Pending
Review via email: mp+262791@code.staging.launchpad.net

Commit message

Hook up DBus client to action runners.

Description of the change

Hook up DBus client to action runners.

Install/uninstall operations now require the progress daemon to be running, but the previews haven't yet changed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Look good to me, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches