Scratch

Merge lp://staging/~kurt.smolderen/scratch/fix-1232291 into lp://staging/scratch/2.x

  1. fix-1232291
  2. Merge into 2.x
Proposed by Kurt Smolderen
Status: Merged
Merged at revision: 1227
Proposed branch: lp://staging/~kurt.smolderen/scratch/fix-1232291
Merge into: lp://staging/scratch/2.x
Diff against target: 69 lines (+25/-20)
1 file modified
src/Services/Document.vala (+25/-20)
To merge this branch: bzr merge lp://staging/~kurt.smolderen/scratch/fix-1232291
Reviewer Review Type Date Requested Status
Mario Guerriero (community) Approve
Pim Vullers (community) Approve
Review via email: mp+188956@code.staging.launchpad.net

Description of the change

Fixes issue lp:1232291 by connecting a 'dummy' handler to the SourceView.buffer.changed signal. This dummy implementation removes itself on the first call from the buffer and connects the 'real' handler instead.

The patch should also work for the trunk version, but as I'm still on Precise, I can't verify due to dependency on zeitgeist-2.0.

To post a comment you must log in.
Revision history for this message
Pim Vullers (pimvullers) wrote :

I've tried this patch against both 2.0.1 and trunk and it works as expected. Files are no longer marked as changed on open. I've already included this patch in the Gentoo ebuilds for scratch. Thanks Kurt for fixing this annoying bug.

review: Approve
Revision history for this message
Cody Garver (codygarver) wrote :

You should target lp:scratch with this instead of lp:scratch/2.x

Revision history for this message
Kurt Smolderen (kurt.smolderen) wrote :

Hey Cody,

Just filed a merge request for trunk. Omitted that at first because I did not have the opportunity to test the fix against trunk.

However, I would still like to see this bug fixed in the 2.x series as well as Luna-users are still using that major version due to zeitgeist dependencies.

Revision history for this message
Cody Garver (codygarver) wrote :

It would get backported

On Tue, Nov 12, 2013 at 2:44 PM, Kurt Smolderen <email address hidden>wrote:

> Hey Cody,
>
> Just filed a merge request for trunk. Omitted that at first because I did
> not have the opportunity to test the fix against trunk.
>
> However, I would still like to see this bug fixed in the 2.x series as
> well as Luna-users are still using that major version due to zeitgeist
> dependencies.
> --
>
> https://code.launchpad.net/~kurt.smolderen/scratch/fix-1232291/+merge/188956
> Your team elementary Apps team is requested to review the proposed merge
> of lp:~kurt.smolderen/scratch/fix-1232291 into lp:scratch/2.x.
>

--
Cody Garver

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

it works good. Nice job!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches