Merge lp://staging/~kuchtam/mir/bug_1195540_after_review into lp://staging/mir

Cool, thanks.

Approved, but could be improved with:
  * Better documentation mentioning you need to compare the result to MIR_VERSION_NUMBER(x,y,z)
  * Remove extra blank link from the cpp file.
  * Acceptance tests to verify the function returns MIR_CLIENT_API_VERSION (when called within the same source tree).

Although I now realize the use of dlsym() mentioned in the bug may negate the need for all this at all, it doesn't hurt...

+1 on the acceptance test. But it's trivial in this case so feel free to top approve if you decide not to indulge.

Fixed in revision: 4009

Thanks, but this should be "==" or "EXPECT_EQ"

+ MIR_CLIENT_API_VERSION_PATCH) >= mir_get_client_api_version());

Fixed in rev: 4010

As mentioned above, I now realize we may never need this function. Simply using dlsym() by itself should suffice. But the bug was open, and it's a great practice exercise.

Just waiting to see if any of ~mir-team objects to this.

Michał,

If nobody has already mentioned it to you, please also complete this:
  https://www.ubuntu.com/legal/contributors/submit

And for the Canonical Project Manager field, enter:
  Kevin Gunn (<email address hidden>)

More information:
  https://www.ubuntu.com/legal/contributors

Hi Daniel,

I have signed document.

I think that this function can be useful because it gives you simple and
quick information about which lib version is use now.

Of course you can do this by dlsym - but each time you must check if
returned address is correct

and when API has big number of functions it can be uncomfortable.

Best Regards,

Michał

2017-02-08 4:09 GMT+01:00 Daniel van Vugt <email address hidden>:

> Michał,
>
> If nobody has already mentioned it to you, please also complete this:
> https://www.ubuntu.com/legal/contributors/submit
>
> And for the Canonical Project Manager field, enter:
> Kevin Gunn (<email address hidden>)
>
> More information:
> https://www.ubuntu.com/legal/contributors
> --
> https://code.launchpad.net/~kuchtam/mir/bug_1195540_after_
> review/+merge/316287
> You are the owner of lp:~kuchtam/mir/bug_1195540_after_review.
>

Huh I wonder why jenkins hasn't run on this? Oh well.