Merge lp://staging/~kroq-gar78/ubuntu/precise/ubuntu-dev-tools/fix-988009 into lp://staging/ubuntu/precise/ubuntu-dev-tools

Proposed by Aditya V
Status: Work in progress
Proposed branch: lp://staging/~kroq-gar78/ubuntu/precise/ubuntu-dev-tools/fix-988009
Merge into: lp://staging/ubuntu/precise/ubuntu-dev-tools
Diff against target: 13 lines (+3/-0)
1 file modified
submittodebian (+3/-0)
To merge this branch: bzr merge lp://staging/~kroq-gar78/ubuntu/precise/ubuntu-dev-tools/fix-988009
Reviewer Review Type Date Requested Status
Andrew Starr-Bochicchio (community) Disapprove
Marc Deslauriers Needs Fixing
Ubuntu branches Pending
Review via email: mp+103595@code.staging.launchpad.net

Description of the change

I added a '--help' option to 'submittodebian'. It opens up its manpage and then exits with code 0.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

Thanks for reminding me to do something about these.

Opening the manpage wouldn't match the rest of ubuntu-dev-tools. The right thing to do here is probably to just use optparse to show some help.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

NACK on the merge proposal. Opening the man page isn't the right thing to do. Please print out a summary of options instead. Thanks.

review: Needs Fixing
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :
review: Disapprove

Unmerged revisions

70. By Aditya V

Added '--help' option to submittodebian, and it links to its manpage. Afterwards, it exits with code 0.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: