charm-advanced-routing

Merge ~koalinux/charm-advanced-routing:dev/upgrade2 into charm-advanced-routing:dev/upgrade2

  1. Git
  2. lp:~koalinux/charm-advanced-routing
  3. dev/upgrade2
  4. Merge into dev/upgrade2
Proposed by José Pekkarinen
Status: Rejected
Rejected by: Alvaro Uria
Proposed branch: ~koalinux/charm-advanced-routing:dev/upgrade2
Merge into: charm-advanced-routing:dev/upgrade2
Diff against target: 72 lines (+18/-22)
2 files modified
lib/routing_entry.py (+4/-2)
lib/routing_validator.py (+14/-20)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Disapprove
Review via email: mp+379378@code.staging.launchpad.net

Commit message

Hi,

This updated merge proposal add fixes for rules that doesn't have
a to-net option set, to address correctly it's table and priority.

Thanks!

José.

To post a comment you must log in.
Revision history for this message
José Pekkarinen (koalinux) wrote :

MP updated, as priority is was only handled in the case of not having
to-net, and it requires to be handled in both cases.

José.

Revision history for this message
José Pekkarinen (koalinux) wrote :

MP has been updated again since the charm in it's current state doesn't validate
a rule without table, not allowing rules that targets the main table, and if
it's explicitly configured to target the main table, it doesn't recognize such
a table.

José

Revision history for this message
Alvaro Uria (aluria) wrote :

A new MP has been pushed since base code has been reworked and this MP would require a different approach. See MP [1].

1. https://code.launchpad.net/~canonical-is-bootstack/charm-advanced-routing/+git/charm-advanced-routing/+merge/379974

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: