Merge lp://staging/~knitzsche/scope-aggregator/featured into lp://staging/scope-aggregator
Proposed by
Kyle Nitzsche
| Status: | Merged |
|---|---|
| Approved by: | Kyle Nitzsche |
| Approved revision: | 206 |
| Merged at revision: | 175 |
| Proposed branch: | lp://staging/~knitzsche/scope-aggregator/featured |
| Merge into: | lp://staging/scope-aggregator |
| Prerequisite: | lp://staging/~knitzsche/scope-aggregator/refactor-handle-methods_add-login_remove-shared-category |
| Diff against target: |
1448 lines (+1015/-49) 15 files modified
README.md (+77/-10) gtests/CMakeLists.txt (+1/-0) gtests/MockRegistry.h (+13/-1) gtests/scope_directory/featured_1.json (+398/-0) gtests/scope_test.cpp (+130/-2) include/aggchildscope.h (+13/-0) include/client.h (+3/-0) include/query.h (+19/-3) include/scope.h (+1/-2) src/aggchildscope.cpp (+37/-0) src/client.cpp (+88/-0) src/handle_results.cpp (+113/-1) src/query.cpp (+9/-0) src/scope.cpp (+6/-25) src/utils.cpp (+107/-5) |
| To merge this branch: | bzr merge lp://staging/~knitzsche/scope-aggregator/featured |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jin (community) | Approve | ||
| Zhang Enwei (community) | Approve | ||
| Gary.Wang | Pending | ||
|
Review via email:
|
|||
Description of the change
This implements the new "Featured Result" feature.
The basic idea is declaring a category that shows a single result. Dev declares a set of scopes to pull from. On each refresh, the result is pulled from the next "pull from" scope, cycling through them and wrapping to the start.
Specification document:
https:/
I tested the built .so in Today, News, Nearby and Photos. All looks good (their behavior is unchanged).
You can test the new feature by installing the scopes as explained in "Working Sample" section of the specification doc linked above.
Note: README.md file in source should completed explain the new "featured" support.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM except not suppress the log.
I verified on china-dashboard and news-china.