Merge lp://staging/~kjtehprogrammer/scratch/drag-n-drop into lp://staging/~elementary-apps/scratch/scratch

Proposed by KJ Lawrence
Status: Merged
Approved by: Mario Guerriero
Approved revision: 1274
Merged at revision: 1280
Proposed branch: lp://staging/~kjtehprogrammer/scratch/drag-n-drop
Merge into: lp://staging/~elementary-apps/scratch/scratch
Diff against target: 83 lines (+43/-2)
2 files modified
src/Widgets/DocumentView.vala (+23/-1)
src/Widgets/SplitView.vala (+20/-1)
To merge this branch: bzr merge lp://staging/~kjtehprogrammer/scratch/drag-n-drop
Reviewer Review Type Date Requested Status
Mario Guerriero (community) Approve
Review via email: mp+215251@code.staging.launchpad.net

Commit message

Drag n Drop enabled for welcome screen and SourceView

Description of the change

Adds the capability to accept drag-and-drops on the welcome screen and on individual documents. Dragging a new document in to sourceview will open it up in another tab automatically.

Should handle multiple files without any issues - I dragged a whole group in through files and it loaded them all in. My only problem is that, for whatever reason, the sourceview drag-and-drop happens twice. It doesn't affect anything because Scratch checks for duplicate files, but its still a pain (and a brief waste of memory).

To post a comment you must log in.
Revision history for this message
Mario Guerriero (mefrio-g) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches