Merge lp://staging/~kjtehprogrammer/maya/fix-1300571 into lp://staging/~elementary-apps/maya/trunk

Proposed by KJ Lawrence
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://staging/~kjtehprogrammer/maya/fix-1300571
Merge into: lp://staging/~elementary-apps/maya/trunk
Diff against target: 105 lines (+12/-16)
2 files modified
src/Application.vala (+2/-2)
src/View/EventDialog.vala (+10/-14)
To merge this branch: bzr merge lp://staging/~kjtehprogrammer/maya/fix-1300571
Reviewer Review Type Date Requested Status
Corentin Noël Disapprove
Review via email: mp+213964@code.staging.launchpad.net

Description of the change

Switch to Gtk.Dialog

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

I have a branch waiting for review that also replace the LightWindow.
It does replace this branch.

review: Disapprove
Revision history for this message
KJ Lawrence (kjtehprogrammer) wrote :

> I have a branch waiting for review that also replace the LightWindow.
> It does replace this branch.

Cool, at least someone is doing it!

Unmerged revisions

541. By KJ Lawrence

Forgot a 'print'...

540. By KJ Lawrence

Change from Gtk.Window/Granite.Widgets.LightWindow to Gtk.Dialog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches