Merge lp://staging/~kiwinote/software-center/bug439613bug530194 into lp://staging/software-center

Proposed by Kiwinote
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp://staging/~kiwinote/software-center/bug439613bug530194
Merge into: lp://staging/software-center
Diff against target: 61 lines (+26/-16)
1 file modified
softwarecenter/app.py (+26/-16)
To merge this branch: bzr merge lp://staging/~kiwinote/software-center/bug439613bug530194
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+22138@code.staging.launchpad.net

Commit message

* softwarecenter/view/app.py:
  - Set correct sensitivity of 'edit > undo,redo,cut,copy,delete,select_all' (LP: #439613, LP: #530194)

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, that looks good (and sorry for the late review :/) ! I did a small change in the merge, please let me know if is correct or if the test on the bounds[0] != bounds[1] is needed for some corner case (I couldn't find one).

Revision history for this message
Michael Vogt (mvo) :
review: Approve
Revision history for this message
Kiwinote (kiwinote) wrote :

I had a look and it should indeed be fine to leave out the "bounds[0] != bounds[1]" as you have done in trunk. Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches