Merge lp://staging/~kissiel/checkbox/output-variable-in-launchers into lp://staging/checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4518
Merged at revision: 4518
Proposed branch: lp://staging/~kissiel/checkbox/output-variable-in-launchers
Merge into: lp://staging/checkbox
Diff against target: 87 lines (+39/-6)
3 files modified
checkbox-ng/docs/launcher-tutorial.rst (+23/-0)
checkbox-ng/launchers/checkbox-cli (+9/-6)
plainbox/plainbox/impl/launcher.py (+7/-0)
To merge this branch: bzr merge lp://staging/~kissiel/checkbox/output-variable-in-launchers
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+307760@code.staging.launchpad.net

Description of the change

This MR adds 'output' setting to [ui] section for launchers.

    That setting specifies which jobs should have their command output printed on the screen. There are 3 options:
    * hide -> (Command output hidden) will be printed for all jobs
    * hide-resource-and-attachment -> will hide output from those two plugin types (as well from (deprecated) local jobs)
    * show (the default setting) -> will print output of all commands

    Note that job that have 'suppress_output' flag will have their output always hidden.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Just tested all combinations, they work as expected. Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches