Checkbox

Merge lp://staging/~kissiel/checkbox/converged-fixes into lp://staging/checkbox

converged-fixes
Merge into trunk

Proposed by Maciej Kisielewski on 2016-04-04

Status:	Merged
Approved by:	Maciej Kisielewski on 2016-04-08
Approved revision:	4295
Merged at revision:	4296
Proposed branch:	lp://staging/~kissiel/checkbox/converged-fixes
Merge into:	lp://staging/checkbox
Diff against target:	58 lines (+9/-3) 3 files modified checkbox-touch/get-libs (+4/-2) plainbox/plainbox/impl/secure/plugins.py (+1/-1) plainbox/plainbox/impl/session/assistant.py (+4/-0)
To merge this branch:	bzr merge lp://staging/~kissiel/checkbox/converged-fixes
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Paul Larson		2016-04-04	Approve on 2016-04-08
Review via email: mp+290907@code.staging.launchpad.net

Description of the change

This MR adds python3-requests-oauthlib

and makes it easier for the future to find out there are missing libs, instead of just showing cryptic 'test plan missing' pop-up.

7b01cdc plainbox:secure:plugins: don't mark plugincollection as loaded unless it is
322c5e3 plainbox:session:assistant: log-error problems from loading providers
dcb3b46 checkbox-touch: add python3-requests-oauthlib to get-libs

Revision history for this message

Paul Larson (pwlars) wrote on 2016-04-06:

I don't see where python3-requests-oauthlib actually gets used here, maybe it was always a missing dep? How was this tested and can I also test it?

review: Needs Information

Revision history for this message

Maciej Kisielewski (kissiel) wrote on 2016-04-07:

> I don't see where python3-requests-oauthlib actually gets used here, maybe it
> was always a missing dep? How was this tested and can I also test it?

It's a dependency of plainbox. On the device, when the providers are being loaded, the pkg_resources finds this lib missing it stops loading the provider mid-way. No test plans are available afterwards.

To test it, build checkbox-converged and run it on a device.

Simplest way:

cd checkbox-touch
./get-libs
./build-me --install

Revision history for this message

Paul Larson (pwlars) wrote on 2016-04-08: