Merge lp://staging/~kinkie/squid/stringng into lp://staging/squid/v4

Proposed by Francesco Chemolli
Status: Needs review
Proposed branch: lp://staging/~kinkie/squid/stringng
Merge into: lp://staging/squid/v4
Diff against target: 4264 lines (+3906/-57)
26 files modified
include/util.h (+1/-1)
src/Makefile.am (+58/-11)
src/MemBlob.cc (+11/-0)
src/MemBlob.h (+2/-0)
src/OutOfBoundsException.h (+22/-0)
src/SBuf.cc (+887/-0)
src/SBuf.cci (+174/-0)
src/SBuf.h (+571/-0)
src/SBufExceptions.cc (+72/-0)
src/SBufExceptions.h (+65/-0)
src/SBufExtras.cc (+104/-0)
src/SBufExtras.h (+66/-0)
src/SBufList.cc (+56/-0)
src/SBufList.h (+62/-0)
src/SBufStream.h (+141/-0)
src/SBufTokenizer.cc (+68/-0)
src/SBufTokenizer.h (+149/-0)
src/SBufUtil.cc (+64/-0)
src/SBufUtil.h (+51/-0)
src/SquidString.h (+0/-38)
src/StrList.h (+65/-7)
src/icmp/Makefile.am (+19/-0)
src/tests/SBufFindTest.cc (+418/-0)
src/tests/SBufFindTest.h (+85/-0)
src/tests/testSBuf.cc (+603/-0)
src/tests/testSBuf.h (+92/-0)
To merge this branch: bzr merge lp://staging/~kinkie/squid/stringng
Reviewer Review Type Date Requested Status
Alex Rousskov Pending
Review via email: mp+70503@code.staging.launchpad.net

Description of the change

String-Buffer class, sporting
- refcounted backing store
- efficient substring operations
- mempools and cachemgr integration
- tokenizer
- ostream interface

To post a comment you must log in.
lp://staging/~kinkie/squid/stringng updated
9552. By Francesco Chemolli

Merged from trunk

9553. By Francesco Chemolli

Fixed unit tests linkage

9554. By Francesco Chemolli

Merged from trunk

9555. By Francesco Chemolli

Fixed leftover merge issue

9556. By Francesco Chemolli

fix merge issue

9557. By Francesco Chemolli

fix main Makefile.am

9558. By Francesco Chemolli

Merged from trunk

9559. By Francesco Chemolli

Updated to reflect latest changes to RefCount API.

9560. By Francesco Chemolli

Fix src/Makefile.am typo

9561. By Francesco Chemolli

renamed SBuf::findAny to find_first_of for consistency with std::string

9562. By Francesco Chemolli

Fixed code formatting in Sbuf
Removed terminate() visibility, functionality now merged into c_str()

9563. By Francesco Chemolli

Review and cleanup.

9564. By Francesco Chemolli

Merged from trunk

9565. By Francesco Chemolli

Merged from trunk

9566. By Francesco Chemolli

Automated source formatting

9567. By Francesco Chemolli

Removed SBufSplit, clarified that StrList is incomplete work in progress

9568. By Francesco Chemolli

Updated debug messages in SBuf

9569. By Francesco Chemolli

Improved SBuf unit tests (thanks Amos). Building but tests failing

9570. By Francesco Chemolli

Fixed SBuf unit tests. To be completed

9571. By Francesco Chemolli

Improved SBuf unit tests

9572. By Francesco Chemolli

Updated debug messages to current standards in SBuf

9573. By Francesco Chemolli

Inlined simple SBufTokenizer methods

9574. By Francesco Chemolli

Merged from trunk

9575. By Francesco Chemolli

Changed some parameters in StrList to const &

9576. By Francesco Chemolli

Removed duplicates from src/Makefile.am

9577. By Francesco Chemolli

Removed some junk that crept in in a merge

9578. By Francesco Chemolli

Merged from trunk

9579. By Francesco Chemolli

Reordered private and protected data members in OutOfBoundsException

9580. By Francesco Chemolli

Applied a more consistent formatting to infix operators in SBuf.cc
Bumped some debugs level statements from DBG_DATA to a more standards-consistent level 8

9581. By Francesco Chemolli

Normalized formatting of infix operators and spacing after commas

9582. By Francesco Chemolli

Renamed some parameters for consistency.
Simplified SBuf constructor.

9583. By Francesco Chemolli

CamelCased some SBuf parameters

9584. By Francesco Chemolli

Fixed SBuf::append(), better layering in SBuf::clear(), removed instance of HERE

9585. By Francesco Chemolli

Clarified parameters, improved some find() corner cases.

9586. By Francesco Chemolli

improved some SBuf::find() corner cases, improved documentation~

9587. By Francesco Chemolli

Renamed SBuf::reserve to SBuf::reserveSpace and created a new SBuf::reserve which matches std::string

9588. By Francesco Chemolli

Increased robustness of SBuf size constraints, clarified documentation

9589. By Francesco Chemolli

Clarified SBuf documentation

9590. By Francesco Chemolli

Reverted changes, SBuf uses reserveSpace now. Clarified parameter names

9591. By Francesco Chemolli

Improved bounds-checking on size parameters.
Moved some variable declarations only when actually needed.

9592. By Francesco Chemolli

Made some SBuf::find corner-cases behave more like std::string
Simplified and corrected SBuf::rfind
Increased accuracy and coverage of SBuf unit tests.

9593. By Francesco Chemolli

Reimplemented SBuf::find, increased consistency with std::string

9594. By Francesco Chemolli

Expanded unit tests for SBuf::find

9595. By Francesco Chemolli

Improved SBuf::rfind and its unit test

9596. By Francesco Chemolli

One more SBuf::rfind unit test

9597. By Francesco Chemolli

Added unit test for SBuf::rfind, renamed unclear variable in rfind

9598. By Francesco Chemolli

reworked SBuf::find_first_of, wrote unit test for it.

9599. By Francesco Chemolli

Merged from trunk

9600. By Francesco Chemolli

Fixed headers, made some variables const in SBuf.cc

9601. By Francesco Chemolli

Sorted headers in SBuf files, de-inlined SBuf::reAlloc

9602. By Francesco Chemolli

Simplified and corrected SBuf::rawSpace

9603. By Francesco Chemolli

Renamed SBuf::StorePrototype to InitialStore

9604. By Francesco Chemolli

Changed SBuf::InitialStore to a static function variable

9605. By Francesco Chemolli

Removed misleading comment

9606. By Francesco Chemolli

Changed SBuf exceptions constructors to explicit

9607. By Francesco Chemolli

Reverted unwanted spacing changes in mem.cc

9608. By Francesco Chemolli

Clarified and corrected OutOfBoundsException

9609. By Francesco Chemolli

Simplified OutOfBoundsException's error message handling

9610. By Francesco Chemolli

Merged from trunk

9611. By Francesco Chemolli

Merged from trunk, fixed shadowing problem

9612. By Francesco Chemolli

Changed testSBuf a bit to clarify some tests better

9613. By Francesco Chemolli

Merge SBuf::rfind fixes from Amos Jeffries

9614. By Francesco Chemolli

Merged from trunk

9615. By Francesco Chemolli

Merged SBuf work by Amos Jeffries and Alex Rousskov, including comprehensive find() testsuite.

9616. By Francesco Chemolli

Changed the behavior of SBuf::find to match the inconsistencies of std::string

9617. By Francesco Chemolli

Make SBuf::find consistent, highlighting a bug in some versions of GNU c++stdlib

9618. By Francesco Chemolli

Apply parameter and constant name conventions more consistently.
Document and enforce consistent behavior in handling startPos for SBuf::find methods
Remove useless includes from testSBuf.h

9619. By Francesco Chemolli

Fix bug in SBuf::compare when max comparison length is specified.

9620. By Francesco Chemolli

Deinlined cow(), inlined commonCompareChecksPost()
Added store-size checks to forceSize()
Improved \0-cleanliness in compare()
Implemented cmp() and casecmp() as shorthand versions of compare()
Improved documentation
Added more unit tests

9621. By Francesco Chemolli

Implemented \0-cleanliness for comparison operations
Added more unit-tests.

9622. By Francesco Chemolli

Merged from trunk

9623. By Francesco Chemolli

Fix linking issue in minimum layer

Unmerged revisions

9623. By Francesco Chemolli

Fix linking issue in minimum layer

9622. By Francesco Chemolli

Merged from trunk

9621. By Francesco Chemolli

Implemented \0-cleanliness for comparison operations
Added more unit-tests.

9620. By Francesco Chemolli

Deinlined cow(), inlined commonCompareChecksPost()
Added store-size checks to forceSize()
Improved \0-cleanliness in compare()
Implemented cmp() and casecmp() as shorthand versions of compare()
Improved documentation
Added more unit tests

9619. By Francesco Chemolli

Fix bug in SBuf::compare when max comparison length is specified.

9618. By Francesco Chemolli

Apply parameter and constant name conventions more consistently.
Document and enforce consistent behavior in handling startPos for SBuf::find methods
Remove useless includes from testSBuf.h

9617. By Francesco Chemolli

Make SBuf::find consistent, highlighting a bug in some versions of GNU c++stdlib

9616. By Francesco Chemolli

Changed the behavior of SBuf::find to match the inconsistencies of std::string

9615. By Francesco Chemolli

Merged SBuf work by Amos Jeffries and Alex Rousskov, including comprehensive find() testsuite.

9614. By Francesco Chemolli

Merged from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches