Merge lp://staging/~khurshid-alam/notify-osd/fix-gnotification-icon into lp://staging/notify-osd

Proposed by Khurshid Alam
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 509
Merged at revision: 509
Proposed branch: lp://staging/~khurshid-alam/notify-osd/fix-gnotification-icon
Merge into: lp://staging/notify-osd
Diff against target: 18 lines (+8/-0)
1 file modified
src/stack.c (+8/-0)
To merge this branch: bzr merge lp://staging/~khurshid-alam/notify-osd/fix-gnotification-icon
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+376177@code.staging.launchpad.net

This proposal supersedes a proposal from 2019-08-20.

Commit message

Support 'image-path' as hint

Both freedesktop notification (https://developer.gnome.org/notification-spec/) spec & Gnotification use image-path as hint where notify-osd only uses image_path.

As a result when one uses themed icon with Gnotification it doesn't show the icon. Support for themed icon landed in https://github.com/GNOME/glib/commit/ec1edef3

Fixes LP: #1840741

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches