Merge lp://staging/~khurshid-alam/indicator-sound/gicon-regression-fix into lp://staging/indicator-sound
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~khurshid-alam/indicator-sound/gicon-regression-fix |
| Merge into: | lp://staging/indicator-sound |
| Diff against target: |
720 lines (+112/-79) 13 files modified
src/accounts-service-access.vala (+1/-1) src/freedesktop-interfaces.vala (+2/-2) src/greeter-broadcast.vala (+5/-5) src/media-player-list-greeter.vala (+1/-1) src/mpris2-interfaces.vala (+8/-8) src/notification.vala (+1/-1) src/options-gsettings.vala (+5/-5) src/volume-control-pulse.vala (+1/-1) src/volume-control.vala (+1/-1) src/volume-warning.vala (+2/-2) tests/integration/CMakeLists.txt (+31/-4) tests/integration/indicator-sound-test-base.cpp (+10/-5) tests/integration/test-indicator.cpp (+44/-43) |
| To merge this branch: | bzr merge lp://staging/~khurshid-alam/indicator-sound/gicon-regression-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher | Needs Fixing | ||
| Marco Trevisan (Treviño) | Pending | ||
|
Review via email:
|
|||
Commit message
* Add symbolic icons to tests.
This is due to a change in glib 2.58. icons now fallback to non-
preferred style appropriately.
see: https:/
https:/
* Disable failed tests (plugExternalMic) for now
* Fix warnings: Use GLib.Error and do not use static const
Description of the change
I believe plugExternalMic tests are failing due some other gicon related regression, probably g_themed_
But I found them harmless, when I plugged mic in, mic volume slider appeared properly in the indicator and is working properly.
Unmerged revisions
- 569. By Khurshid Alam
-
Fix build for focal
- 568. By Khurshid Alam
-
Disable failed tests for now
- 567. By Khurshid Alam
-
Fix warnings: Use GLib.Error and do not use static const
- 566. By Khurshid Alam
-
Add symbolic icons to tests.
This is due to a change in glib 2.58. icons now fallbacks to non-preferred style appropriately.
see: https://gitlab. gnome.org/ GNOME/glib/ merge_requests/ 72
https://gitlab. gnome.org/ GNOME/glib/ issues/ 1513 - 565. By CI Train Bot Account
-
Releasing 12.10.2+
18.10.20180612- 0ubuntu1 - 564. By Khurshid Alam
-
Recommend accountsservice
-ubuntu- schemas. Due to missing schemas, indicator-sound simply spams syslog when it tries to get properties from com.ubuntu.
AccountsService .Sound (LP: #1700680) - 563. By CI Train Bot Account
-
Releasing 12.10.2+
18.04.20180420. 3-0ubuntu1
Thank you for your work, unsure the glib behaviour change can be described as 'regression' and that they plan to change the behaviour though. The test here should be adapted rather than commented out (and if you do you need to comment them, then there should at least be a code comment describing what needs to be fixed/changed later)