Merge lp://staging/~khurshid-alam/indicator-appmenu/ignore-desktop into lp://staging/indicator-appmenu

Proposed by Khurshid Alam
Status: Merged
Merged at revision: 285
Proposed branch: lp://staging/~khurshid-alam/indicator-appmenu/ignore-desktop
Merge into: lp://staging/indicator-appmenu
Prerequisite: lp://staging/~khurshid-alam/indicator-appmenu/fix-build-disco
Diff against target: 125 lines (+11/-17)
5 files modified
src/gdk-get-func.c (+3/-3)
src/indicator-appmenu.c (+4/-4)
src/window-menu-dbusmenu.c (+2/-4)
src/window-menu-model.c (+2/-4)
src/window-menu.c (+0/-2)
To merge this branch: bzr merge lp://staging/~khurshid-alam/indicator-appmenu/ignore-desktop
Reviewer Review Type Date Requested Status
Marco Trevisan (TreviƱo) Pending
Review via email: mp+366990@code.staging.launchpad.net

Commit message

* Don't use the deprecated g_type_class_add_private

* Use X11 specific error trap functions

* Do not to track menus for desktop_windows. Fixes LP: #1827411

Description of the change

Bamf somehow not considering desktop window as valid bamf window (see https://paste.ubuntu.com/p/wz32KF7Kqx/). As a result when indicator-appmenu tries to track menu it fails. For now we are ignoring tracking desktop windows in indicator-appmenu.

To post a comment you must log in.
285. By Khurshid Alam

Do not to track menus for desktop_windows. Fixes LP:#1827411

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

I figured out what is happening. Before nautilus & nautilus-desktop was the same binary (same for nemo), bamf used to track nautilus for desktop menu. But after the split, the code was never adapted in bamf. But for now, this works.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches