unity-lens-applications

Merge lp://staging/~khadgaray/unity-lens-applications/fix-lockdown into lp://staging/unity-lens-applications

fix-lockdown
Merge into trunk

Proposed by Ritesh Khadgaray on 2012-07-03

Status:

Rejected

Rejected by:

Didier Roche-Tolomelli on 2019-02-12

Proposed branch:

lp://staging/~khadgaray/unity-lens-applications/fix-lockdown

Merge into:

lp://staging/unity-lens-applications

Diff against target:

16 lines (+6/-0)

1 file modified

src/daemon.vala (+6/-0)

To merge this branch:

bzr merge lp://staging/~khadgaray/unity-lens-applications/fix-lockdown

Undecided

Confirmed

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2013-04-13
Didier Roche-Tolomelli			Needs Fixing on 2012-07-05
Mikkel Kamstrup Erlandsen (community)		2012-07-03	Needs Information on 2012-07-04
Review via email: mp+113251@code.staging.launchpad.net

Description of the change

Allows an admin to disable command run dialog based on gnome security policies.

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2012-07-04:

This adds a hard runtime dep on the org.gnome.desktop.lockdown schema. Does this imply a new dependency for the package as well?

review: Needs Information

Revision history for this message

Ritesh Khadgaray (khadgaray) wrote on 2012-07-04:

> This adds a hard runtime dep on the org.gnome.desktop.lockdown schema. Does
> this imply a new dependency for the package as well?

Unity already depends on this via libgnome-desktop-3-4, which needs gsettings-desktop-schemas.

-- ritz

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2012-07-05:

I would rather the check happening when the lens is started and then listening to the key changing than after you did a search and ready to activate it.

In that case, we should display a friendly message to the user rather than afterwards :)

Also yeah, as told on IRC, the dependency should be specified directly. And it needs tests ;)

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-13:

FAILED: Continuous integration, rev:287
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~khadgaray/unity-lens-applications/fix-lockdown/+merge/113251/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-lens-applications-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-i386-ci/3/console