Merge lp://staging/~kgunn72/unity/8_CODING_updates into lp://staging/unity/8.0

Proposed by kevin gunn
Status: Rejected
Rejected by: Michał Sawicz
Proposed branch: lp://staging/~kgunn72/unity/8_CODING_updates
Merge into: lp://staging/unity/8.0
Diff against target: 117 lines (+44/-17)
1 file modified
CODING (+44/-17)
To merge this branch: bzr merge lp://staging/~kgunn72/unity/8_CODING_updates
Reviewer Review Type Date Requested Status
Michał Sawicz Disapprove
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+171433@code.staging.launchpad.net

Commit message

update to the CODING file

Description of the change

update to the CODING file

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

49 +Options can be passed to test the lock screen
50 +$ ./run -p OR -k
51 +
52 +-p is for pin lock, for which the default prompt answer is "1234"
53 +-k is for keylock passphrase, for which the default prompt answer is "password"

I think enumerating the options is the task of "./run --help". Would be good to inform the default passwords there.

CODING is meant for a new developer to get started. So, IMHO, it should be about the basic stuff only. I wasn't aware of those run options and default passwords myself. :-D

Revision history for this message
kevin gunn (kgunn72) wrote :

> 49 +Options can be passed to test the lock screen
> 50 +$ ./run -p OR -k
> 51 +
> 52 +-p is for pin lock, for which the default prompt answer is "1234"
> 53 +-k is for keylock passphrase, for which the default prompt answer is
> "password"
>
> I think enumerating the options is the task of "./run --help". Would be good
> to inform the default passwords there.
>
> CODING is meant for a new developer to get started. So, IMHO, it should be
> about the basic stuff only. I wasn't aware of those run options and default
> passwords myself. :-D

I'll go out on a limb and say most folks don't run --help, so think of this as nice advertisement about -p/-k....note i didn't put -f or -m. Remember we are also using this text on the wiki to promote playing around with unity8. And sorry, i didn't see your MP (doh) should we just merge yours in here ?

Revision history for this message
Michał Sawicz (saviq) wrote :
review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: