Merge lp://staging/~kgunn72/unity-mir/um-mir-0.1.8 into lp://staging/unity-mir

Proposed by kevin gunn
Status: Rejected
Rejected by: kevin gunn
Proposed branch: lp://staging/~kgunn72/unity-mir/um-mir-0.1.8
Merge into: lp://staging/unity-mir
Diff against target: 14 lines (+2/-2)
1 file modified
debian/control (+2/-2)
To merge this branch: bzr merge lp://staging/~kgunn72/unity-mir/um-mir-0.1.8
Reviewer Review Type Date Requested Status
Michał Sawicz Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Gerry Boland (community) Approve
Review via email: mp+212008@code.staging.launchpad.net

Commit message

bump debian dep to mir0.1.8

Description of the change

bump debian dep to mir0.1.8

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Why do we need changes like that? Did API change?

FWIW, 0.1.8 >= 0.1.7 already, and this change only adds confusion, as unity-mir happily works against both 0.1.7 and 0.1.8, AFAICT. While building the package, dpkg will mark the runtime dependency between unity-mir and mir to the actual binary version of the mir it built against, and that system should be enough. We should only bump the mir requirement when there's actual code changes needed in unity-mir that would be incompatible with earlier mir.

review: Disapprove
Revision history for this message
kevin gunn (kgunn72) wrote :

> Why do we need changes like that? Did API change?
>
> FWIW, 0.1.8 >= 0.1.7 already, and this change only adds confusion, as unity-
> mir happily works against both 0.1.7 and 0.1.8, AFAICT. While building the
> package, dpkg will mark the runtime dependency between unity-mir and mir to
> the actual binary version of the mir it built against, and that system should
> be enough. We should only bump the mir requirement when there's actual code
> changes needed in unity-mir that would be incompatible with earlier mir.

you are right, it isn't technically needed. this only became the way-of-doing in order to have a rebuild forced, back in the old days. but now with ci train, you are right we should be able to have an empty commit rebuild since its in our control.
I'm going to start trying the empty commit method. I'll just double check with the release team in case there was some other non-obvious reason we were bumping.

Unmerged revisions

205. By kevin gunn

bump debian dep to mir0.1.8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches