Python Jenkins

Merge lp://staging/~kenrumer/python-jenkins/build_info into lp://staging/~python-jenkins-developers/python-jenkins/trunk

build_info
Merge into trunk

Proposed by Ken Rumer on 2012-02-29

Status:	Merged
Merged at revision:	13
Proposed branch:	lp://staging/~kenrumer/python-jenkins/build_info
Merge into:	lp://staging/~python-jenkins-developers/python-jenkins/trunk
Diff against target:	73 lines (+38/-0) 2 files modified doc/index.rst (+10/-0) jenkins/__init__.py (+28/-0)
To merge this branch:	bzr merge lp://staging/~kenrumer/python-jenkins/build_info
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
James Page		2012-02-29	Approve on 2012-03-02
Review via email: mp+95243@code.staging.launchpad.net

Commit message

Added build info method

Description of the change

Try this again.

Gets build information from Jenkins. Can use to get the status of a build. Loop until the build is complete, return the artifact URL(s).

Example usage:
     import jenkins
     import time
     j = jenkins.Jenkins('http://'+kwargs['ci_host']+':'+kwargs['ci_port'], kwargs['ci_username'], kwargs['ci_password'])

next_build_number = j.get_job_info('build_'+kwargs['vcs_server_type'])['nextBuildNumber']

Revision history for this message

James Page (james-page) wrote on 2012-03-01:

Thanks for re-doing this merge proposal Ken.

A few comments:

1) Please could you add documentation to the method in the python code as well as index.rst - helps folk who 'pydoc jenkins'.

2) The string handling for errors is inconsistent with the rest of the package:

Please use:

raise JenkinsException('job[%s] number[%d] does not exist'%(name, number))

instead of:

raise JenkinsException('job[!s] number[!d] does not exist'.format(name, number))

I appreciate that both produce the same result but I would like to keep the package consistent.

Other than that looks good - I'll merge once you have made the above amendments.

Cheers

James

review: Needs Fixing

Revision history for this message

Ken Rumer (kenrumer) wrote on 2012-03-01:

Cool, thanks for the info
On Mar 1, 2012 2:05 AM, "James Page" <email address hidden> wrote:

> Review: Needs Fixing
>
> Thanks for re-doing this merge proposal Ken.
>
> A few comments:
>
> 1) Please could you add documentation to the method in the python code as
> well as index.rst - helps folk who 'pydoc jenkins'.
>
> 2) The string handling for errors is inconsistent with the rest of the
> package:
>
> Please use:
>
> raise JenkinsException('job[%s] number[%d] does not exist'%(name, number))
>
> instead of:
>
> raise JenkinsException('job[!s] number[!d] does not exist'.format(name,
> number))
>
> I appreciate that both produce the same result but I would like to keep
> the package consistent.
>
> Other than that looks good - I'll merge once you have made the above
> amendments.
>
> Cheers
>
> James
>
> --
> https://code.launchpad.net/~kenrumer/python-jenkins/build_info/+merge/95243
> You are the owner of lp:~kenrumer/python-jenkins/build_info.
>