Merge lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1385286 into lp://staging/ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1385286
Merge into: lp://staging/ubuntu-system-settings/rtm-14.09
Diff against target: 244 lines (+40/-45)
11 files modified
plugins/about/PageComponent.qml (+1/-1)
plugins/about/Storage.qml (+2/-2)
plugins/about/StorageItem.qml (+1/-1)
plugins/about/storageabout.cpp (+0/-11)
plugins/about/storageabout.h (+0/-1)
plugins/system-update/PageComponent.qml (+5/-28)
src/CMakeLists.txt (+3/-1)
src/main.cpp (+1/-0)
src/utils.cpp (+17/-0)
src/utils.h (+8/-0)
tests/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1385286
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Review via email: mp+242118@code.staging.launchpad.net

Commit message

Move formatSize into a new Utilities class in the qml context and call this from the updates panel to consistently display sizes

Description of the change

Move formatSize into a new Utilities class in the qml context and call this from the updates panel to consistently display sizes

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like we are not doing more rtm landing, so cleaning the list a bit, that one is rather going to be including with the vivid rebase

Unmerged revisions

940. By Ken VanDine

Move formatSize into a new Utilities class in the qml context and call this from the updates panel to consistently display sizes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches