Merge lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1377286 into lp://staging/ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1377286
Merge into: lp://staging/ubuntu-system-settings/rtm-14.09
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/notifications/PageComponent.qml (+1/-1)
To merge this branch: bzr merge lp://staging/~ken-vandine/ubuntu-system-settings/rtm-1377286
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher (community) Approve
Review via email: mp+242115@code.staging.launchpad.net

Commit message

[notifications] update strings to match the design

Description of the change

[notifications] update strings to match the design

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, as discussed in previous mps, changing a string invalidate the UI translations the new langpack update, do we have a plan to handle that, or do we consider it fine for e.g spanish customers to have their phone UI regress to english after an ota update?

review: Needs Information
Revision history for this message
Sebastien Bacher (seb128) wrote :

Setting as comment approved, but we need to organize the landing with a langpack update to not regress on translations

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like we are not doing more rtm landing, so cleaning the list a bit, that one is rather going to be including with the vivid rebase

Unmerged revisions

940. By Ken VanDine

[notifications] update strings to match the design

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches