Merge lp://staging/~ken-vandine/ubuntu-system-settings/lp1390629 into lp://staging/ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Iain Lane
Approved revision: 1192
Merged at revision: 1196
Proposed branch: lp://staging/~ken-vandine/ubuntu-system-settings/lp1390629
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 43 lines (+7/-1)
2 files modified
debian/control (+1/-0)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+6/-1)
To merge this branch: bzr merge lp://staging/~ken-vandine/ubuntu-system-settings/lp1390629
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+241150@code.staging.launchpad.net

Commit message

Specify DaemonVersion for upower to support upower 0.99 on vivid

Description of the change

Specify DaemonVersion for upower to support upower 0.99 on vivid

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1190. By Ken VanDine

fixed pep8 failure

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Can you think of a way to make this dynamic? The code is so it would be good if the test was too (otherwise we should bump the versions in d/control)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
1191. By Ken VanDine

make DaemonVersion dynamic

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1192. By Ken VanDine

Make ubuntu-system-settings-autopilot depend on gir1.2-upowerglib-1.0

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, thanks! I'll fix that in dbusmock as well, to default to 0.99 these days.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches