Merge lp://staging/~ken-vandine/ubuntu-system-settings/better_handling_of_no_ofono into lp://staging/ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 1694
Merged at revision: 1716
Proposed branch: lp://staging/~ken-vandine/ubuntu-system-settings/better_handling_of_no_ofono
Merge into: lp://staging/ubuntu-system-settings
Prerequisite: lp://staging/~ken-vandine/ubuntu-system-settings/no_s_i_d
Diff against target: 38 lines (+3/-3)
3 files modified
plugins/cellular/plugin/cellular-plugin.cpp (+1/-1)
plugins/hotspot/plugin/hotspot-plugin.cpp (+1/-1)
plugins/phone/plugin/phone-plugin.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~ken-vandine/ubuntu-system-settings/better_handling_of_no_ofono
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Jonas G. Drange (community) Approve
Review via email: mp+304646@code.staging.launchpad.net

Commit message

cellular, phone, hotspot: Don't default to visible

Description of the change

cellular, phone, hotspot: Don't default to visible

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Make sense.

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1694
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/143/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1396/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1396
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1255
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1255
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1255
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1251/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1251/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1251/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1251/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1251/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1251/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1251/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1251
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1251/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1251/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/143/rebuild

review: Needs Fixing (continuous-integration)
1695. By Ken VanDine

merged trunk

1696. By Ken VanDine

Merged prereq

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches