Merge lp://staging/~ken-vandine/signon-ui/webview_improvements into lp://staging/signon-ui

Proposed by Ken VanDine
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 102
Merged at revision: 100
Proposed branch: lp://staging/~ken-vandine/signon-ui/webview_improvements
Merge into: lp://staging/signon-ui
Diff against target: 76 lines (+49/-1)
2 files modified
debian/changelog (+7/-0)
src/browser-process/webview.qml (+42/-1)
To merge this branch: bzr merge lp://staging/~ken-vandine/signon-ui/webview_improvements
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+164409@code.staging.launchpad.net

Commit message

Added some tweaks to the webview for to improve the experience on ubuntu touch devices

Description of the change

Added some tweaks to the webview for to improve the experience on ubuntu touch devices

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:100
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-ui-raring-amd64-ci/20

Click here to trigger a rebuild:
http://s-jenkins:8080/job/signon-ui-ci/20/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Please check the comments, looks like the apostrophe is transformed into "’".

review: Needs Fixing
101. By Ken VanDine

cleaned up comments

Revision history for this message
Ken VanDine (ken-vandine) wrote :

I've fixed the comments

102. By Ken VanDine

updated from trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:102
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-ui-saucy-amd64-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/signon-ui-ci/21/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Excellent, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: