Merge lp://staging/~ken-vandine/reminders-app/lp1316942 into lp://staging/reminders-app
Proposed by
Ken VanDine
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | David Planella | ||||
Approved revision: | 122 | ||||
Merged at revision: | 124 | ||||
Proposed branch: | lp://staging/~ken-vandine/reminders-app/lp1316942 | ||||
Merge into: | lp://staging/reminders-app | ||||
Diff against target: |
46 lines (+11/-7) 2 files modified
src/app/qml/ui/EditNotePage.qml (+0/-1) src/app/qml/ui/EditNoteView.qml (+11/-6) |
||||
To merge this branch: | bzr merge lp://staging/~ken-vandine/reminders-app/lp1316942 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+218662@code.staging.launchpad.net |
Commit message
Updated for API changes in content-hub (LP: #1316942)
Description of the change
Updated for API changes in content-hub (LP: #1316942)
To post a comment you must log in.
Thanks a lot Ken!
However, this did not quite work for me:
- Upon tapping on the image icon on the edit note view, the Gallery was correctly open, and I could choose a picture
- When I tapped on Pick, then the Gallery got closed as expected, but focus did not come back to Reminders, I was back on the click scope
- When I tapped on the Reminders icon in Recent apps, then it gained the focus as expected, but instead of the picture the note shows a question mark icon
Here's the log of the whole process: http:// pastebin. ubuntu. com/7411419/