Merge lp://staging/~ken-vandine/reminders-app/lp1316942 into lp://staging/reminders-app

Proposed by Ken VanDine
Status: Merged
Approved by: David Planella
Approved revision: 122
Merged at revision: 124
Proposed branch: lp://staging/~ken-vandine/reminders-app/lp1316942
Merge into: lp://staging/reminders-app
Diff against target: 46 lines (+11/-7)
2 files modified
src/app/qml/ui/EditNotePage.qml (+0/-1)
src/app/qml/ui/EditNoteView.qml (+11/-6)
To merge this branch: bzr merge lp://staging/~ken-vandine/reminders-app/lp1316942
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+218662@code.staging.launchpad.net

Commit message

Updated for API changes in content-hub (LP: #1316942)

Description of the change

Updated for API changes in content-hub (LP: #1316942)

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Thanks a lot Ken!

However, this did not quite work for me:

- Upon tapping on the image icon on the edit note view, the Gallery was correctly open, and I could choose a picture
- When I tapped on Pick, then the Gallery got closed as expected, but focus did not come back to Reminders, I was back on the click scope
- When I tapped on the Reminders icon in Recent apps, then it gained the focus as expected, but instead of the picture the note shows a question mark icon

Here's the log of the whole process: http://pastebin.ubuntu.com/7411419/

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

The interesting bit in your log is this:

attaching file file:///home/phablet/.cache/com.ubuntu.reminders/HubIncoming/1/DSC_2121.JPG on note Note(0xa5cf40)
cannot determine mime type of file "DSC_2121.JPG"

Can you check to see if that file is there? And if so, is it a valid jpeg? I've tried several times on my device without fail.

However, I had trouble getting the cross-build working, so I just copied those 2 qml files to my device. It all worked fine for me.

Revision history for this message
David Planella (dpm) wrote :

The file is there and seems to be a valid JPEG in the sense that I can
display it (I don't know how else I can validate it). I've just pulled it
from /home/phablet/Pictures and uploaded it to
http://people.canonical.com/~dpm/tmp/DSC_2121.JPG

On Wed, May 7, 2014 at 7:09 PM, Ken VanDine <email address hidden>wrote:

> The interesting bit in your log is this:
>
> attaching file
> file:///home/phablet/.cache/com.ubuntu.reminders/HubIncoming/1/DSC_2121.JPG
> on note Note(0xa5cf40)
> cannot determine mime type of file "DSC_2121.JPG"
>
> Can you check to see if that file is there? And if so, is it a valid
> jpeg? I've tried several times on my device without fail.
>
> However, I had trouble getting the cross-build working, so I just copied
> those 2 qml files to my device. It all worked fine for me.
> --
>
> https://code.launchpad.net/~ken-vandine/reminders-app/lp1316942/+merge/218662
> You are reviewing the proposed merge of
> lp:~ken-vandine/reminders-app/lp1316942 into lp:reminders-app.
>

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Was it also in /home/phablet/.cache/com.ubuntu.reminders/HubIncoming/1/DSC_2121.JPG ?

Have you tried any other images?

Revision history for this message
David Planella (dpm) wrote :

~/.cache/com.ubuntu.reminders/HubIncoming/1 is empty, but I'm not sure if
this is due to any post-cleanup.

I'll try next with other images.

On Wed, May 7, 2014 at 9:09 PM, Ken VanDine <email address hidden>wrote:

> Was it also in
> /home/phablet/.cache/com.ubuntu.reminders/HubIncoming/1/DSC_2121.JPG ?
>
> Have you tried any other images?
> --
>
> https://code.launchpad.net/~ken-vandine/reminders-app/lp1316942/+merge/218662
> You are reviewing the proposed merge of
> lp:~ken-vandine/reminders-app/lp1316942 into lp:reminders-app.
>

Revision history for this message
David Planella (dpm) wrote :

So I've now tried it with another image that I took from the Ubuntu camera and it works. However, Reminders still loses focus after picking the image on Gallery and needs to be re-clicked on the Recent apps section in the click scope.

As per the image I tried to load earlier, I don't really know why it wouldn't load it, but I've left it online [1] in case anyone wants to do further testing.

I think the issue I had is probably not something that can be fixed in this MP, but rather on content hub itself, thus approving nevertheless.

[1] http://people.canonical.com/~dpm/tmp/DSC_2121.JPG

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches