mediaplayer-app

Merge lp://staging/~ken-vandine/mediaplayer-app/nodisplay into lp://staging/mediaplayer-app

  1. nodisplay
  2. Merge into trunk
Proposed by Ken VanDine
Status: Needs review
Proposed branch: lp://staging/~ken-vandine/mediaplayer-app/nodisplay
Merge into: lp://staging/mediaplayer-app
Diff against target: 19 lines (+2/-2)
2 files modified
data/mediaplayer-app.desktop.in.in (+1/-1)
setup/gui/mediaplayer-app.desktop (+1/-1)
To merge this branch: bzr merge lp://staging/~ken-vandine/mediaplayer-app/nodisplay
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Andrew Hayzen (community) Approve
Review via email: mp+319212@code.staging.launchpad.net

Commit message

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

Description of the change

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, this removes the errors when running the content-hub-peer-hook-wrapper and prevents it from being shown in the app drawer

review: Approve
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:441
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/2/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2309
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2308
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2130/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/2/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

441. By Ken VanDine

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches