Merge lp://staging/~ken-vandine/libappindicator/gtk3 into lp://staging/libappindicator
Proposed by
Ken VanDine
Status: | Merged |
---|---|
Merged at revision: | 179 |
Proposed branch: | lp://staging/~ken-vandine/libappindicator/gtk3 |
Merge into: | lp://staging/libappindicator |
Diff against target: |
190 lines (+36/-14) 7 files modified
bindings/Makefile.am (+4/-0) docs/reference/Makefile.am (+6/-1) example/Makefile.am (+7/-1) example/simple-client.c (+3/-2) src/Makefile.am (+1/-1) src/appindicator3-0.1.pc.in (+1/-1) tests/Makefile.am (+14/-8) |
To merge this branch: | bzr merge lp://staging/~ken-vandine/libappindicator/gtk3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+47411@code.staging.launchpad.net |
Description of the change
More GTK fixes, the /indicator-
To post a comment you must log in.
review approve
On Tue, 2011-01-25 at 16:07 +0000, Ken VanDine wrote: applet- developers) /code.launchpad .net/~ken- vandine/ libappindicator /gtk3/+ merge/47411 application/ libappindicator /set_menu test is failing though and I am not sure why. Makefile. am' Makefile. am 2009-12-16 19:32:39 +0000 Makefile. am 2011-01-25 16:06:53 +0000 /Makefile. am' Makefile. am 2010-12-04 02:44:18 +0000 Makefile. am 2011-01-25 16:06:53 +0000 libappindicator 3 libappindicator VERSION= 2 CFLAGS= -I$(top_ srcdir) -I$(top_builddir) $(GTK_DEBUG_FLAGS) LIBS=$( top_builddir) /gtk/$( gtktargetlib) CFLAGS= -I$(top_ srcdir) -I$(top_srcdir)/src -I$(top_srcdir)/src $(LIBRARY_CFLAGS) LIBS=$( top_builddir) /src/libappindi cator.la $(LIBRARY_LIBS) LIBS=$( top_builddir) /src/$( DOC_MODULE) .la $(LIBRARY_LIBS) /gtk-doc. local.make Makefile. am' /src/libappindi cator.la /src/libappindi cator$( VER).la client- test-icon. png simple- client. c' simple- client. c 2010-11-09 23:01:37 +0000 simple- client. c 2011-01-25 16:06:53 +0000 set_sensitive (target, !GTK_WIDGET_ IS_SENSITIVE (target)); set_sensitive (target, !gtk_widget_ is_sensitive (target)); set_from_ stock (GTK_IMAGE (GTK_IMAGE_ MENU_ITEM (widget)->image), set_from_ stock (GTK_IMAGE (gtk_image_ menu_item_ get_image ( SIZE_MENU) ;
> Ken VanDine has proposed merging lp:~ken-vandine/libappindicator/gtk3 into lp:libappindicator.
>
> Requested reviews:
> Indicator Applet Developers (indicator-
>
> For more details, see:
> https:/
>
> More GTK fixes, the /indicator-
> differences between files attachment (review-diff.txt)
> === modified file 'bindings/
> --- bindings/
> +++ bindings/
> @@ -1,3 +1,7 @@
> +if USE_GTK3
> +SUBDIRS = mono
> +else
> SUBDIRS = \
> mono \
> python
> +endif
>
> === modified file 'docs/reference
> --- docs/reference/
> +++ docs/reference/
> @@ -9,7 +9,12 @@
> # of using the various options.
>
> # The name of the module, e.g. 'glib'.
> +if USE_GTK3
> +DOC_MODULE=
> +else
> DOC_MODULE=
> +endif
> +
>
> # Uncomment for versioned docs and specify the version of the module, e.g. '2'.
> #DOC_MODULE_
> @@ -91,7 +96,7 @@
> # e.g. GTKDOC_
> # e.g. GTKDOC_
> GTKDOC_
> -GTKDOC_
> +GTKDOC_
>
> # This includes the standard gtk-doc make rules, copied by gtkdocize.
> include $(top_srcdir)
>
> === modified file 'example/
> --- example/Makefile.am 2010-12-04 03:37:58 +0000
> +++ example/Makefile.am 2011-01-25 16:06:53 +0000
> @@ -1,3 +1,9 @@
> +if USE_GTK3
> +VER=3
> +else
> +VER=
> +endif
> +
>
> check_PROGRAMS = \
> simple-client
> @@ -17,7 +23,7 @@
>
> simple_client_LDADD = \
> $(LIBRARY_LIBS) \
> - $(top_builddir)
> + $(top_builddir)
>
> EXTRA_DIST = \
> simple-
>
> === modified file 'example/
> --- example/
> +++ example/
> @@ -86,13 +86,14 @@
> {
> GtkWidget *target = (GtkWidget *)data;
>
> - gtk_widget_
> + gtk_widget_
> }
>
> static void
> image_clicked_cb (GtkWidget *widget, gpointer data)
> {
> - gtk_image_
> + gtk_image_
> + GTK_IMAGE_MENU_ITEM (widget))),
> GTK_STOCK_OPEN, GTK_ICON_
> }
>
>
> === modified file 'src/Makefile.am'
> --- src/Makefile.am 2011-01-13 23:36:29 +0000
> +++ src/Makefile.am 2011-01-25 16:06:53 +0000
> @@ -45,7 +45,7 @@
>
> DISTCLEANFILES...