The Me Menu

Merge lp://staging/~ken-vandine/indicator-me/dbusmenu-0.4 into lp://staging/indicator-me

  1. dbusmenu-0.4
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Merged at revision: 116
Proposed branch: lp://staging/~ken-vandine/indicator-me/dbusmenu-0.4
Merge into: lp://staging/indicator-me
Diff against target: 125 lines (+18/-21)
3 files modified
configure.ac (+4/-4)
src/entry-menu-item.c (+3/-4)
src/indicator-me.c (+11/-13)
To merge this branch: bzr merge lp://staging/~ken-vandine/indicator-me/dbusmenu-0.4
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Ken VanDine Needs Resubmitting
Review via email: mp+45753@code.staging.launchpad.net

Description of the change

 * ported to dbusmenu-glib-0.4
 * removed check for dbusmenu-gtk, it isn't used

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

You need to get the callback in indicator-me.c "entry_prop_change_cb" which still is based on a GValue.

review: Needs Fixing
Revision history for this message
Ted Gould (ted) wrote :

Oh, there is a "about_me_prop_change_cb" as well.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Ok, updated those as well

review: Needs Resubmitting
lp://staging/~ken-vandine/indicator-me/dbusmenu-0.4 updated
116. By Ken VanDine

Ported about_me_prop_change_cb and entry_prop_change_cb to dbusmenu-glib-0.4

Revision history for this message
Ted Gould (ted) wrote :

Cool!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches