Merge lp://staging/~ken-vandine/falldown/generate_translations into lp://staging/falldown

Proposed by Ken VanDine
Status: Merged
Merged at revision: 60
Proposed branch: lp://staging/~ken-vandine/falldown/generate_translations
Merge into: lp://staging/falldown
Diff against target: 14 lines (+2/-2)
1 file modified
falldown.pro (+2/-2)
To merge this branch: bzr merge lp://staging/~ken-vandine/falldown/generate_translations
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Review via email: mp+269697@code.staging.launchpad.net

Commit message

Fixed app dir for generating translations

Description of the change

Fixed app dir for generating translations

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Thanks for spotting this, unfortunately doesn't work as expected

Well, that works because the *mo files are included in the right directory in the click package, but the app is always shown in english and not in the local language...

I need to investigate further before merging this!

Revision history for this message
Ken VanDine (ken-vandine) wrote :

> Thanks for spotting this, unfortunately doesn't work as expected
>
> Well, that works because the *mo files are included in the right directory in
> the click package, but the app is always shown in english and not in the local
> language...
>
> I need to investigate further before merging this!

Thanks!

Revision history for this message
Ken VanDine (ken-vandine) wrote :

> Thanks for spotting this, unfortunately doesn't work as expected
>
> Well, that works because the *mo files are included in the right directory in
> the click package, but the app is always shown in english and not in the local
> language...
>
> I need to investigate further before merging this!

You might need to set the translations domain in the .desktop file?

X-Ubuntu-Gettext-Domain=

60. By Ken VanDine

bindtextdomain

61. By Ken VanDine

We don't need binddomain

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Ah, we need a MainView. I've confirmed this works with a MainView as the parent of Game. I didn't propose that in this branch because I had some issues with the properties set in the game component.

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Thanks for helping me on this, indeed with a MainView works well :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: